Skip to content

[Fleet] Hide from UI some shipper options#151341

Merged
criamico merged 3 commits intoelastic:mainfrom
criamico:shipper_follow_up
Feb 16, 2023
Merged

[Fleet] Hide from UI some shipper options#151341
criamico merged 3 commits intoelastic:mainfrom
criamico:shipper_follow_up

Conversation

@criamico
Copy link
Copy Markdown
Member

@criamico criamico commented Feb 15, 2023 •
edited
Loading

Closes #147613
Closes #147613

Summary

Follow up of #145755

Introduce a feature flag (showExperimentalShipperOptions) to hide from the UI the shipper options that are still not ready to be shown to the user. The only available parameters for now should be the following, as per comment:

  • Mem queue
  • Max batch size
  • Queue flush timeout

Testing steps

  • Add a new output and in the yaml editor add one of the following and save it;
shipper: {}

or

shipper:
  enabled: true
  • Edit the output, the shipper section should appear under "advanced options"

Screenshot 2023-02-15 at 16 30 01

  • Generated full agent policy:

Screenshot 2023-02-16 at 15 05 20

There are more parameters visible, but they're set to null

Checklist

@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 release_note:feature Makes this part of the condensed release notes labels Feb 15, 2023
@criamico
Copy link
Copy Markdown
Member Author

criamico commented Feb 16, 2023

@elasticmachine merge upstream

@criamico criamico marked this pull request as ready for review February 16, 2023 14:00
@criamico criamico requested a review from a team as a code owner February 16, 2023 14:00
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 16, 2023

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Feb 16, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Feb 16, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 931.1KB 931.3KB +196.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 124.4KB 124.4KB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@criamico criamico merged commit b94c777 into elastic:main Feb 16, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fleet] Align UI Shipper options with shipper configs

5 participants

@criamico @elasticmachine @kibana-ci @nchaulet @kibanamachine