[8.6] [Fleet] Add check for legacy managed_by field in datastream mappings (#149504)#149583
Merged
criamico merged 1 commit intoelastic:8.6from Jan 26, 2023
Merged
Conversation
…lastic#149504) ## Summary Closes elastic#147605 ### Description Clusters that exist since pre-8.0 might have data streams that have `managed_by: ingest_manager` in their` _meta` properties, instead of the current value `managed_by: fleet`. However, with the merge of elastic#143300, the data streams view filters out any data streams that don't have `managed_by: fleet` metadata, so when updating from 7.x to 8.6.x no data streams are returned. ### Solution It was decided to simply add an additional check in the data stream handler to allow for "legacy" metadata, and to avoid doing migrations that can be dangerous for the users data. ### Testing I'm looking for a way to reliably test this locally - I've only managed to reproduce it on cloud (cherry picked from commit 49ff27e) # Conflicts: # x-pack/plugins/fleet/server/routes/data_streams/handlers.ts
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation