Conversation
|
Can one of the admins verify this patch? |
|
jenkins, test this |
simianhacker
left a comment
There was a problem hiding this comment.
Probably should come up with some kind of max width and then truncate the label with ellipsis.
|
Right. I'll do that tomorrow. |
|
@shaharmor bump on this in prep to get all TSVB PRs closed before we move it to prettier formatted |
4b82e5e to
50e2cd5
Compare
|
@mattapperson @simianhacker done. PR rebased. |
| flex-direction: column; | ||
| height: auto; | ||
| width: 100%; | ||
| overflow: auto; |
There was a problem hiding this comment.
This should probably be checked with kibana vis team.
When overflow: auto, if the tooltip is high, it crosses the panel dimensions and gets cut.
Without overflow, the tooltip simply goes beyond the panel (Which is fine I guess).
I didn't find any other issues with it
There was a problem hiding this comment.
It's probably best to leave this change out. EUI has a new tooltip component which should be (if not already) an easy fit into TSVB.
@simianhacker @mattapperson does TSVB use EUI tooltip yet, or is it in the near future?
|
If this is going to go in, it needs a bump from @simianhacker to re-review after the changes and @mattapperson to give a review. Let's try to get it sooner rather than later while it still can be merged without conflicts. |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💔 Build Failed |
|
Hey @simianhacker @elastic/kibana-app can you take another look at the changes? Hey @shaharmor can you rebase? all the .less styles is now refactored to SASS. |
💔 Build Failed |
|
Ping @shaharmor |
|
Closing as it looks like interest has dropped on this. This will also be solved when the TSVB timeseries chart has the new chart library replacement. |
|
Interest has not dropped, I just didn't have the time to rebase yet. If you say this will already be fixed in the new TSVB, we can just wait for that |
related to #13864 (Maybe it fixes it?)
This PR makes the TSVB tooltip show a row for each series.
It also aligns the value to the right end of the tooltip for consistency with the newly added values
@simianhacker I wasn't sure how to align the tooltip correctly.
When there are multiple yaxis, the tooltip can be rendered below/above the chart in some cases.