[Reporting] Allow Reporting APIs to work when there is no headless browser#148226
Merged
tsullivan merged 2 commits intoelastic:7.17from Jan 7, 2023
Merged
[Reporting] Allow Reporting APIs to work when there is no headless browser#148226tsullivan merged 2 commits intoelastic:7.17from
tsullivan merged 2 commits intoelastic:7.17from
Conversation
vadimkibana
approved these changes
Dec 30, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows developers on Mac to use the CSV generation APIs in 7.17. However, screenshot-type reports will continue to not be supported.
In 7.17, there was no Kibana Reporting support for the Mac ARM processor. Now that many developers use that type of computer, they may be blocked from using any Reporting API at all, including CSV generation APIs.
This change makes a correction to not block access to Reporting APIs when there is not registered headless browser. If a user attempts to generate a report in 7.17 on a server running an unsupported browser, they will receive an error message.
Unblocks: #148030