Skip to content

[kibana-plugin CLI] add optimize task and skip-optimize option on install task#14515

Closed
gwintzer wants to merge 5 commits intoelastic:5.6from
gwintzer:optimize-task-in-kibana-plugin-cli
Closed

[kibana-plugin CLI] add optimize task and skip-optimize option on install task#14515
gwintzer wants to merge 5 commits intoelastic:5.6from
gwintzer:optimize-task-in-kibana-plugin-cli

Conversation

@gwintzer
Copy link
Copy Markdown

@gwintzer gwintzer commented Oct 23, 2017

Hi,

Here's a PR according to the issue #6057.

  • Add a new optimize task to the kibana-plugin CLI
  • Add an option --skip-optimize for the existing install task

Example :

# install all your plugins faster
./bin/kibana-plugin install --skip-optimize plugin1
./bin/kibana-plugin install --skip-optimize plugin2

# finally run the optimize task once
./bin/kibana-plugin optimize

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 23, 2017

Can one of the admins verify this patch?

@kimjoar kimjoar added the Team:Operations Kibana-Operations Team label Oct 23, 2017
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Oct 26, 2017

@gwintzer Thanks for the PR, but we're no longer adding any features to 5.6. Can you retarget this for master instead? This ensures that the feature is available in all future versions, and we'll backport the change down to the next feature release.

@FireBurn
Copy link
Copy Markdown

FireBurn commented Nov 16, 2017

Is there a version anywhere that applies to version 6?

@gwintzer
Copy link
Copy Markdown
Author

gwintzer commented Nov 16, 2017

I will try to retarget the PR on master soon to allow a backport on v5/v6

@gwintzer gwintzer mentioned this pull request Nov 16, 2017
Closed
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Nov 16, 2017

@gwintzer Thanks for opening up a new PR against master. I'm going to close this one in favor of that one.

PR against master: #14991

@epixa epixa closed this Nov 16, 2017
@cuff-links cuff-links mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Team:Operations Kibana-Operations Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gwintzer @elasticmachine @epixa @FireBurn @kimjoar