Avoid request scoped services#14482
Closed
rhoboat wants to merge 11 commits intoelastic:new-platformfrom
rhoboat:tmp-avoid-request-scoped-services
Closed
Avoid request scoped services#14482rhoboat wants to merge 11 commits intoelastic:new-platformfrom rhoboat:tmp-avoid-request-scoped-services
rhoboat wants to merge 11 commits intoelastic:new-platformfrom
rhoboat:tmp-avoid-request-scoped-services
Conversation
15 tasks
added 11 commits
November 14, 2017 19:30
- for plugins, inject elasticsearch instead of server object - for UiSettingsService, inject SavedObjectsService - import and export dashboards actually will need to have SavedObjectsService injected as well - http/ acts like a plugin that gets UiSettingsService & SavedObjectsService from kibana as dependencies - SavedObjectsService needs elasticsearch injected because we don't have it otherwise - make updateMetaData private in short url lookup
This was referenced Apr 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged.
In the new platform, rather than passing in the request object to functions in plugins that need to use the SavedObjectsService, IndexPatternsService, or UiSettingsService. Plugins in the new platform can specify what services they depend on, whether they are internal to kibana core or other plugins.
This code is meant to show example code. Please look at example_plugins/short_url/ for an annotated example and example_plugins/port_dashboards/ for a realistic implementation of the existing functionality.