Skip to content

Revert "Revert "[Guided onboarding] Fix multiple API requests when fetching guide state (#144160)""#144459

Merged
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:guided_onboarding/8.6_revert_api_fix_back
Nov 2, 2022
Merged

Revert "Revert "[Guided onboarding] Fix multiple API requests when fetching guide state (#144160)""#144459
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:guided_onboarding/8.6_revert_api_fix_back

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech commented Nov 2, 2022

Reverts a4445f9 that reverted #144160 and fixes types errors.

@yuliacech yuliacech added release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.6.0 labels Nov 2, 2022
@yuliacech yuliacech marked this pull request as ready for review November 2, 2022 16:59
@yuliacech yuliacech requested a review from a team as a code owner November 2, 2022 16:59
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 23.9KB 24.2KB +365.0B
Unknown metric groups

API count

id before after diff
@kbn/guided-onboarding 22 23 +1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 103 108 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 104 110 +6
securitySolution 517 523 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit 610f04a into elastic:main Nov 2, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Nov 2, 2022
@yuliacech yuliacech deleted the guided_onboarding/8.6_revert_api_fix_back branch November 22, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants