Skip to content

[Lens][Agg based Pie] Navigate to lens functional tests. #143372

Merged
VladLasitsa merged 1 commit intoelastic:mainfrom
VladLasitsa:navigate-to-lens-agg-based-pie-functional-tests
Oct 14, 2022
Merged

[Lens][Agg based Pie] Navigate to lens functional tests. #143372
VladLasitsa merged 1 commit intoelastic:mainfrom
VladLasitsa:navigate-to-lens-agg-based-pie-functional-tests

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa commented Oct 14, 2022

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations
  • Invalid aggregations
  • More than 3 split splices
  • Respect type (donut/pie)

@VladLasitsa VladLasitsa self-assigned this Oct 14, 2022
@VladLasitsa VladLasitsa added Feature:Pie Chart Pie chart visualization feature test_xpack_functional Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v8.6.0 labels Oct 14, 2022
@VladLasitsa VladLasitsa mentioned this pull request Oct 14, 2022
Closed
28 tasks
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 14, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypePie 8.7KB 8.7KB +37.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa marked this pull request as ready for review October 14, 2022 15:03
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 14, 2022 15:03
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa requested a review from flash1293 October 14, 2022 15:03
flash1293
flash1293 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladLasitsa VladLasitsa merged commit 583454f into elastic:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels

backport:skip This PR does not require backporting Feature:Lens Feature:Pie Chart Pie chart visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// test_xpack_functional v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VladLasitsa @kibana-ci @elasticmachine @flash1293