[Security/EBT] Skip user_id registration on anonymous pages#143280
Merged
afharo merged 2 commits intoelastic:mainfrom Oct 13, 2022
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
028301e to
ba48354
Compare
legrego
approved these changes
Oct 13, 2022
Member
legrego
left a comment
There was a problem hiding this comment.
LGTM pending the one suggestion below. Thank you!
x-pack/plugins/security/public/analytics/analytics_service.test.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to avoid registering the context provider
user_idon anonymous pages because we anticipate they will be undefined.It's more relevant for our analysis to check when it's
undefinedfor non-anonymous pages.Checklist
For maintainers