Skip to content

[Lens][Agg based Metric] Navigate to lens functional tests.#143269

Merged
Kuznietsov merged 22 commits intoelastic:mainfrom
Kuznietsov:navigate-to-lens-agg-based-metric-functional-tests
Oct 17, 2022
Merged

[Lens][Agg based Metric] Navigate to lens functional tests.#143269
Kuznietsov merged 22 commits intoelastic:mainfrom
Kuznietsov:navigate-to-lens-agg-based-metric-functional-tests

Conversation

@Kuznietsov
Copy link
Copy Markdown
Contributor

@Kuznietsov Kuznietsov commented Oct 13, 2022

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations or field type.
  • Invalid aggregations
  • Color rules

Flaky tests check: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1424

@Kuznietsov Kuznietsov requested a review from alexwizp October 13, 2022 10:24
@Kuznietsov Kuznietsov self-assigned this Oct 13, 2022
@Kuznietsov Kuznietsov added the WIP Work in progress label Oct 13, 2022
@Kuznietsov Kuznietsov added loe:small Small Level of Effort test_xpack_functional Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This PR does not require backporting v8.6.0 labels Oct 13, 2022
@Kuznietsov Kuznietsov removed the WIP Work in progress label Oct 13, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review October 13, 2022 15:07
@Kuznietsov Kuznietsov requested a review from a team as a code owner October 13, 2022 15:07
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2022
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-tests

# Conflicts:
#	x-pack/test/functional/apps/lens/group3/open_in_lens/agg_based/metric.ts
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kuznietsov Kuznietsov merged commit 4b88273 into elastic:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// test_xpack_functional v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants