Skip to content

[TSVB][Lens] Added support of Variance aggregation for navigate to lens#143209

Merged
VladLasitsa merged 6 commits intoelastic:mainfrom
VladLasitsa:navigate_to_lens_tsvb_add_variance_support
Oct 14, 2022
Merged

[TSVB][Lens] Added support of Variance aggregation for navigate to lens#143209
VladLasitsa merged 6 commits intoelastic:mainfrom
VladLasitsa:navigate_to_lens_tsvb_add_variance_support

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa commented Oct 12, 2022

Summary

Completes part of #138236

Added support of 'Variance' aggregation. This aggregation convert to formula - pow(standard_deviation(fieldName), 2)

TSVB:
Снимок экрана 2022-10-12 в 18 13 43

After conversion in Lens:
Снимок экрана 2022-10-12 в 18 14 10

@VladLasitsa VladLasitsa self-assigned this Oct 12, 2022
@VladLasitsa VladLasitsa added release_note:enhancement Feature:TSVB TSVB (Time Series Visual Builder) Feature:Lens backport:skip This PR does not require backporting v8.6.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Oct 12, 2022
@VladLasitsa VladLasitsa mentioned this pull request Oct 12, 2022
Closed
28 tasks
@VladLasitsa VladLasitsa marked this pull request as ready for review October 13, 2022 10:40
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 13, 2022 10:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 13, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa requested a review from flash1293 October 13, 2022 10:40
@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Oct 14, 2022 •
edited
Loading

Why don't we allow the transition for moving average?

It can be moving_average(pow(standard_deviation(machine.ram), 2))

Same question for Derivative.

@VladLasitsa
Copy link
Copy Markdown
Contributor Author

VladLasitsa commented Oct 14, 2022 •
edited
Loading

Why don't we allow the transition for moving average?

It can be moving_average(pow(standard_deviation(machine.ram), 2))

Same question for Derivative.

@stratoula good catch! Forgot to add new case for converting parent pipeline aggs. Fixed.

stratoula
stratoula approved these changes Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine now, LGTM

@VladLasitsa
Copy link
Copy Markdown
Contributor Author

VladLasitsa commented Oct 14, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 14, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 379 380 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 502.6KB 503.2KB +590.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit 3cf9778 into elastic:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

@Kuznietsov Kuznietsov Awaiting requested review from Kuznietsov

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@VladLasitsa VladLasitsa

Labels

backport:skip This PR does not require backporting Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VladLasitsa @elasticmachine @stratoula @kibana-ci @kibanamachine