[Lens][TSVB] Functional tests for converting of Metric.#143164
Merged
Kuznietsov merged 13 commits intoelastic:mainfrom Oct 13, 2022
Merged
[Lens][TSVB] Functional tests for converting of Metric.#143164Kuznietsov merged 13 commits intoelastic:mainfrom
Kuznietsov merged 13 commits intoelastic:mainfrom
Conversation
… navigate-to-lens-tsvb-metric-functional-tests
28 tasks
…d not valid panels.
# Conflicts: # test/functional/page_objects/visual_builder_page.ts # x-pack/test/functional/apps/lens/group3/open_in_lens/tsvb/timeseries.ts
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
Contributor
|
This looks great Yaroslav! Thank you a lot for adding these tests. Can we please run it on the flaky tester 100 times just to be sure that we don't introduce any major flakiness? Thanx! |
stratoula
approved these changes
Oct 13, 2022
Contributor
stratoula
left a comment
There was a problem hiding this comment.
We ran it 100 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1420 and it was successful! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes part of #138236
Sibling pipelineParent pipeline