[Lens][TSVB] Functional tests for converting of Timeseries.#143057
Merged
Kuznietsov merged 11 commits intoelastic:mainfrom Oct 12, 2022
Merged
Conversation
28 tasks
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
reviewed
Oct 12, 2022
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Looks mostly good, left two notes
x-pack/test/functional/apps/lens/group3/open_in_lens/tsvb/timeseries.ts
Outdated
Show resolved
Hide resolved
flash1293
approved these changes
Oct 12, 2022
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Good to merge after the small nits are addressed
VladLasitsa
reviewed
Oct 12, 2022
x-pack/test/functional/apps/lens/group3/open_in_lens/tsvb/timeseries.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/lens/group3/open_in_lens/tsvb/timeseries.ts
Outdated
Show resolved
Hide resolved
…series.ts Co-authored-by: Uladzislau Lasitsa <vlad.lasitsa@gmail.com>
…series.ts Co-authored-by: Uladzislau Lasitsa <vlad.lasitsa@gmail.com>
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes part of #138236