[APM] Refactoring metrics route#142770
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
gbamparop
left a comment
There was a problem hiding this comment.
Thanks for doing this!
| import { ServiceMetrics } from './service_metrics'; | ||
| import { ServiceNodeOverview } from './service_node_overview'; | ||
|
|
||
| export function Metrics() { |
There was a problem hiding this comment.
Difficult ask: Can we find a more narrow definition of metrics? We have many types of metrics: transaction metrics, service metrics, runtime metrics, system metrics.
| import { isJavaAgentName, isJRubyAgent } from '../../../../common/agent_name'; | ||
| import { useApmServiceContext } from '../../../context/apm_service/use_apm_service_context'; | ||
| import { ServiceMetrics } from './service_metrics'; | ||
| import { ServiceNodeOverview } from './service_node_overview'; |
There was a problem hiding this comment.
Isn't this jvm specific? I think we should make that clear in the name:
| import { ServiceNodeOverview } from './service_node_overview'; | |
| import { JvmMetricsOverview } from './jvm_metric_overview'; |
There was a problem hiding this comment.
In the same vain, you should also rename the backend APIs and files:
x-pack/plugins/apm/server/routes/service_nodes/route.ts -> x-pack/plugins/apm/server/routes/metrics/route.ts
There's also the API:
GET /internal/apm/services/{serviceName}/serviceNodes which should be renamed to something like:
GET /internal/apm/services/{serviceName}/metrics/nodes
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Related to #142328.
/services/${serviceName}/nodes/route and redirect it to/services/${serviceName}/metrics/Metricsfolder.