Skip to content

[Lens] Rename datasources#142553

Merged
stratoula merged 29 commits intoelastic:mainfrom
stratoula:lens-rename-datasources
Oct 12, 2022
Merged

[Lens] Rename datasources#142553
stratoula merged 29 commits intoelastic:mainfrom
stratoula:lens-rename-datasources

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Oct 4, 2022 •
edited
Loading

Summary

Closes #137723

This PR does the following things:

  • Created a datasources folder and moved the two datasources inside
  • Renamed the "textBasedLanguages" datasource to textBased (also renaming of types)
  • Renamed the "indexPattern" datasource to formBased (also renaming of types)

Note1: I havent renamed css classes or data subjects. We could do it on a followup PR
Note2: If you have SOs with the text based language will fail because this PR also changes the id of this datasource. This is ok as we are introducing text based languages in Lens on this minor.
Note 3: This PR introduces a migration script.

How to test

  • Test that old by value and by reference Lens visualizations work as expected (ensure that migrations have run)
  • Test that new Lens visualizations work as expected for the formBased datasource
  • Test that new Lens visualizations work as expected for textBased datasource

The functional tests run successfully which is a great indicator that everything works as expected but I would appreciate a manual testing to ensure that everything works fine.

@stratoula stratoula changed the title Lens rename datasources [Lens] Rename datasources Oct 4, 2022
@stratoula stratoula requested a review from flash1293 October 5, 2022 10:09
@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v8.6.0 labels Oct 5, 2022
@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented Oct 5, 2022

@stratoula I went through all the changes and it looks fine to me.

@stratoula stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Oct 5, 2022
@stratoula stratoula marked this pull request as ready for review October 5, 2022 13:54
@stratoula stratoula requested review from a team as code owners October 5, 2022 13:54
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2022

Pinging @elastic/uptime (Team:uptime)

jgowdyelastic
jgowdyelastic approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@stratoula stratoula requested a review from a team as a code owner October 6, 2022 11:56
@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented Oct 6, 2022

@elastic/security-solution can you help me with these test failures? I don't get why they started failing today after I merged with main. I don't see how they are relevant with my changes but maybe I am wrong, I would appreciate some help here! Thanx

@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented Oct 10, 2022

@stratoula Checking the CI for the security solution failure, it looks like you updated this in some places where it shouldn't be updated because it's saved objects running through migration:
Screenshot 2022-10-10 at 09 33 56

I think it's x-pack/plugins/security_solution/server/lib/risk_score/prebuilt_saved_objects/saved_object/host_risk_score_dashboards.ts and x-pack/plugins/security_solution/server/lib/risk_score/prebuilt_saved_objects/saved_object/user_risk_score_dashboards.ts

@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented Oct 10, 2022

aaah thanx @flash1293, I think you are right! Reverted ❤️

pgayvallet
pgayvallet approved these changes Oct 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to SO types LGTM

patrykkopycinski
patrykkopycinski approved these changes Oct 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset management LGTM

rudolf
rudolf approved these changes Oct 10, 2022
View reviewed changes
@weltenwort weltenwort self-requested a review October 11, 2022 10:22
weltenwort
weltenwort approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin changes LGTM

jonathan-buttner
jonathan-buttner approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cases changes look good.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 12, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Alerts detection rules table auto-refresh should disable auto refresh when any rule selected and enable it after rules unselected

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 565 566 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 571.3KB 571.3KB -3.0B
infra 1.0MB 1.0MB -3.0B
lens 1.3MB 1.3MB -185.0B
ml 3.4MB 3.4MB -3.0B
observability 530.0KB 530.0KB -6.0B
osquery 1.0MB 1.0MB -6.0B
securitySolution 6.6MB 6.6MB -75.0B
ux 162.9KB 162.8KB -3.0B
total -284.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 29.1KB 29.1KB -48.0B
Unknown metric groups

API count

id before after diff
lens 656 657 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 8c4976f into elastic:main Oct 12, 2022
@jughosta jughosta mentioned this pull request Oct 13, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weltenwort weltenwort weltenwort approved these changes

@rudolf rudolf rudolf approved these changes

@flash1293 flash1293 flash1293 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// technical debt Improvement of the software architecture and operational architecture v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Rename "indexpattern" datasource