[RAM] Move Connectors to own page by Zacqary · Pull Request #142485 · elastic/kibana

Zacqary · 2022-10-03T15:38:14Z

Summary

Moves Connectors tab to own page in Stack Management
Closes #142373

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2022-10-05T21:08:07Z

Pinging @elastic/response-ops (Team:ResponseOps)

XavierM · 2022-10-06T16:55:27Z

x-pack/plugins/actions/server/feature.ts

  app: [],
  order: FEATURE_ORDER,
  management: {
-    insightsAndAlerting: ['triggersActions'],


we should use the new constant CONNECTORS_PLUGIN_ID

This constant is in the triggers_actions_ui plugin, not the actions plugin, and attempting to import it causes an unresolvable no_boundary_crossing error. Because triggersActions is already here as a literal and not as an imported constant I think we should just leave it as-is.

XavierM · 2022-10-06T17:24:01Z

@mdefazio Do you want the two buttons Create connector?

XavierM · 2022-10-06T17:24:43Z

breadcrumbs is not showing connectors

XavierM · 2022-10-06T17:37:54Z

I tried to change the privileges of Actions and connector and everything is working as expected! that was great to see!

mdefazio · 2022-10-06T17:50:02Z

Here's an updated mockup showing the empty state

Remove header when there are no tabs (EUI guidelines)

I think this will be slightly different for Rules, since that will have two tabs....but I'm checking on that. Will get you that soon.

@lcawl Can you take a look at the page description and empty prompt text? I threw this in as a placeholder. The current copy felt out dated. We will also need an updated page description for the Rules page.

XavierM · 2022-10-06T18:05:30Z

x-pack/plugins/triggers_actions_ui/public/application/lib/doc_title.ts

  let updatedTitle: string;

  switch (page) {
+    case 'logs':


Thank you for adding that!

JiaweiWu · 2022-10-06T18:06:04Z

It seems like we're changing the path of the connectors page from management/insightsAndAlerting/triggersActions/connectors to management/insightsAndAlerting/triggersActionsConnectors. I did a quick string search for references to the old path and it seems like get_import_warnings.ts has a reference to it. I think we should take a look at references to the old URL so we don't get stale links 🙂

mdefazio · 2022-10-06T20:30:53Z

@mdefazio Where do we want the Documentation button to link to?

Requesting confirmation from @lcawl , but perhaps this link

Zacqary · 2022-10-10T16:39:26Z

@elasticmachine merge upstream

XavierM · 2022-10-12T15:19:11Z

x-pack/plugins/triggers_actions_ui/public/application/app.tsx

+          exact
+          path={routeToConnectors}
+          render={() => {
+            const newPath = window.location.pathname.replace(


instead of doing that, we can just use navigateToApp, it will be more the kibana way, what do you think?

…bana into 142373-connector-page

Zacqary · 2022-10-12T16:49:04Z

@elastic/kibana-reporting-services @elastic/kibana-app-services @elastic/platform-deployment-management @elastic/ml-ui I apparently need code owner approval to achieve this sort order:

We had multiple plugins using the same order: n value, so the actual order of the menu ended up being determined by what order Webpack imports and compiles everything. So in order to slot Connectors in the right spot while reducing confusion, I unfortunately had to touch a whole bunch of different plugins.

alisonelizabeth

Deployment Management changes LGTM (changing watcher nav order)

kibana-ci · 2022-10-12T21:00:40Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0727d33

Failed CI Steps

Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution

Test Failures

[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Alerts detection rules table auto-refresh should disable auto refresh when any rule selected and enable it after rules unselected

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	510	511	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	672.6KB	676.8KB	+4.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	99.1KB	100.3KB	+1.2KB

History

💔 Build #79871 failed 8064419
💛 Build #79513 was flaky c6fe573
💛 Build #79193 was flaky 04cb621
💚 Build #78836 succeeded 6b3833d
💚 Build #78788 succeeded df5cda5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mattkime

app services changes lgtm, reporting changes too. I think its fine for you to merge without an official reporting approval.

alvarezmelissa87

Code LGTM ⚡

Move Connectors to own page

53cf56f

Zacqary added Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.6.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// release_note:enhancement labels Oct 3, 2022

Zacqary added 13 commits October 3, 2022 09:29

Move create connector button to header

d29319d

Update permissions IDs

ec708a2

Fix some tests

27033f4

Merge remote-tracking branch 'upstream/main' into 142373-connector-page

e5b27d4

Test fixes

62d4593

Fix more tests

4fed947

Fix more tests

296a135

Fix FTR 7

15ba21d

Fix jest

f39e255

Fix FTR 4

4194f00

Fix FTR 6

f6f5f6f

Merge remote-tracking branch 'upstream/main' into 142373-connector-page

be9c506

Fix translations

3ec5e8e

Zacqary marked this pull request as ready for review October 5, 2022 21:08

Zacqary requested a review from a team as a code owner October 5, 2022 21:08

Merge remote-tracking branch 'upstream/main' into 142373-connector-page

df5cda5

XavierM reviewed Oct 6, 2022

View reviewed changes

Fix breadcrumbs

682aad5

XavierM reviewed Oct 6, 2022

View reviewed changes

Zacqary added 2 commits October 6, 2022 13:16

Update empty prompt text

1a588be

Update import warning url

6b3833d

Zacqary enabled auto-merge (squash) October 6, 2022 20:58

Zacqary disabled auto-merge October 6, 2022 20:58

kibanamachine and others added 2 commits October 10, 2022 10:39

Merge branch 'main' into 142373-connector-page

58f8348

Add documentation buttons

04cb621

Zacqary enabled auto-merge (squash) October 11, 2022 16:04

Redirect legacy connectors URL

c6fe573

XavierM reviewed Oct 12, 2022

View reviewed changes

XavierM and others added 4 commits October 12, 2022 11:22

Merge branch 'main' into 142373-connector-page

78847b7

Fix app redirection

b9ffb87

Merge branch '142373-connector-page' of https://github.com/Zacqary/ki…

4f6fc65

…bana into 142373-connector-page

Fix management plugin order

73df869

Zacqary requested review from a team as code owners October 12, 2022 16:38

Uniquify plugin ordering

8064419

Zacqary requested review from a team as code owners October 12, 2022 16:45

XavierM approved these changes Oct 12, 2022

View reviewed changes

Fix FTR 21

0727d33

alisonelizabeth approved these changes Oct 12, 2022

View reviewed changes

mattkime approved these changes Oct 13, 2022

View reviewed changes

alvarezmelissa87 approved these changes Oct 13, 2022

View reviewed changes

Zacqary merged commit ec98f01 into elastic:main Oct 13, 2022

kibanamachine added the backport:skip This PR does not require backporting label Oct 13, 2022

XavierM mentioned this pull request Nov 21, 2022

[RAM] Refactor rules page to use EuiPageTemplate #144070

Merged

Conversation

Zacqary commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 5, 2022

Uh oh!

XavierM Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

Zacqary Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

XavierM commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XavierM commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XavierM commented Oct 6, 2022

Uh oh!

mdefazio commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XavierM Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

JiaweiWu commented Oct 6, 2022

Uh oh!

mdefazio commented Oct 6, 2022

Uh oh!

Zacqary commented Oct 10, 2022

Uh oh!

XavierM Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zacqary commented Oct 12, 2022

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Oct 12, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

mattkime left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zacqary commented Oct 3, 2022 •

edited

Loading

XavierM commented Oct 6, 2022 •

edited

Loading

XavierM commented Oct 6, 2022 •

edited

Loading

mdefazio commented Oct 6, 2022 •

edited

Loading

XavierM Oct 12, 2022 •

edited

Loading

mattkime left a comment •

edited

Loading