[Visualizations] Navigate to lens agg based vis library tests.#141353
Merged
Kuznietsov merged 358 commits intoelastic:mainfrom Sep 29, 2022
Merged
[Visualizations] Navigate to lens agg based vis library tests.#141353Kuznietsov merged 358 commits intoelastic:mainfrom
Kuznietsov merged 358 commits intoelastic:mainfrom
Conversation
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…into navigate-to-lens-agg-based-pie-vis
…is' into navigate-to-lens-agg-based-vis-lib-tests
…ladLasitsa/kibana into navigate-to-lens-agg-based-vis
…ns-agg-based-vis-lib-tests
…-based-vis-lib-tests # Conflicts: # src/plugins/visualizations/common/convert_to_lens/types/configurations.ts
…dLasitsa/kibana into navigate-to-lens-tsvb-metric
…-based-vis-lib-tests
# Conflicts: # src/plugins/chart_expressions/expression_partition_vis/common/expression_functions/__snapshots__/pie_vis_function.test.ts.snap # src/plugins/chart_expressions/expression_partition_vis/common/expression_functions/pie_vis_function.ts # src/plugins/chart_expressions/expression_partition_vis/public/expression_renderers/partition_vis_renderer.tsx # src/plugins/vis_types/pie/public/convert_to_lens/configurations/index.test.ts # src/plugins/vis_types/pie/public/convert_to_lens/configurations/index.ts # src/plugins/vis_types/pie/public/convert_to_lens/index.test.ts # src/plugins/vis_types/pie/public/convert_to_lens/index.ts # src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/metric/index.ts # src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/metric/palette.ts # src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/supported_metrics.ts # src/plugins/vis_types/timeseries/public/convert_to_lens/metric/index.ts # src/plugins/visualizations/common/convert_to_lens/constants.ts # src/plugins/visualizations/common/convert_to_lens/lib/convert/date_histogram.ts # src/plugins/visualizations/common/convert_to_lens/lib/convert/parent_pipeline.ts # src/plugins/visualizations/common/convert_to_lens/lib/convert/percentile.ts # src/plugins/visualizations/common/convert_to_lens/lib/convert/percentile_rank.ts # src/plugins/visualizations/common/convert_to_lens/lib/convert/terms.ts # src/plugins/visualizations/common/convert_to_lens/lib/metrics/formula.ts # src/plugins/visualizations/common/convert_to_lens/lib/utils.ts # src/plugins/visualizations/common/convert_to_lens/types/configurations.ts # src/plugins/visualizations/public/convert_to_lens/schemas.test.ts # src/plugins/visualizations/public/convert_to_lens/schemas.ts # src/plugins/visualizations/public/visualize_app/components/visualize_top_nav.tsx # x-pack/plugins/lens/public/trigger_actions/visualize_agg_based_vis_actions.ts # x-pack/test/functional/apps/lens/group3/tsvb_open_in_lens.ts
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @VladLasitsa @Kunzetsov |
stratoula
approved these changes
Sep 29, 2022
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM! Code review only! Thanx for adding all these tests Yaroslav :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes part of #138236.
Added tests for visualizations convert_to_lens library.