Update kubernetes templates for elastic-agent#138260
Closed
elasticmachine wants to merge 2 commits intomainfrom
Closed
Update kubernetes templates for elastic-agent#138260elasticmachine wants to merge 2 commits intomainfrom
elasticmachine wants to merge 2 commits intomainfrom
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
Contributor
Author
|
Pinging @elastic/fleet (Team:Fleet) |
…-ref HEAD~1..HEAD --fix'
gsantoro
approved these changes
Aug 8, 2022
9 tasks
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
nchaulet
reviewed
Aug 8, 2022
| # If FLEET_ENROLLMENT_TOKEN is empty then KIBANA_HOST, KIBANA_FLEET_USERNAME, KIBANA_FLEET_PASSWORD are needed | ||
| - name: FLEET_ENROLLMENT_TOKEN | ||
| value: "token-id" | ||
| value: "" |
Member
There was a problem hiding this comment.
Looks like it's needed as we replace this by the ENROLLMENT token in the instructions
Suggested change
| value: "" | |
| value: "token-id" |
Contributor
There was a problem hiding this comment.
| value: "changeme" | ||
| value: "" | ||
| # The Elasticsearch host to communicate with | ||
| - name: ES_HOST |
Contributor
There was a problem hiding this comment.
just wondering if this variable wasn't skipped on purpose - for standalone mode ES_HOST will get rendered to the actual value in configmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by https://fleet-ci.elastic.co/job/elastic-agent/job/elastic-agent-mbp/job/PR-837/28/