[Unified search] Make resizable button as the EUI one#137698
[Unified search] Make resizable button as the EUI one#137698stratoula merged 13 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
|
@MichaelMarcialis I think I managed to move the styles from eui to our editor. 🤞 |
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Amazing, @stratoula! Thanks so much for putting this together. I've left some comments below for your review.
Would it be possible to move the resizable button so that it appears on top of the border that divides the unified search UI and the rest of the page content (see example GIF below)? I think doing so would be a nice touch.
|
My walking away piece of advice: Don't copy/paste direct EUI styles/code. Ask EUI to export this button at the top level: https://github.com/elastic/eui/blob/main/src/components/resizable_container/resizable_button.tsx It'll keep in sync with any a11y or style changes and you can request general improvements that will benefit all usages. 😸 |
|
Yes @cchaos you are right. I created an issue here elastic/eui#6100 |
Thanks for that advice, @cchaos. @stratoula, since you've already done the work here, I say going ahead with this PR and then switching when EUI exports the button makes sense to me. The issue you created will remind us not to forget to make the switch. |
|
@MichaelMarcialis I think I addressed everything! |
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Thanks for making these updates, @stratoula. Leaving you a few additional comments below for your review.
Also, I noticed that in expanded mode the space between editor footer and border is smaller than the space space between border and page content. On initial glance, it looks like this might be happening because of the negative margining that exists on the editor footer's EuiFlexGroup. Would it be possible to fix this issue so that the space between both areas is equal (8px from border)?
…-ref HEAD~1..HEAD --fix'
…la/kibana into unified-resizable-button
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Hey, @stratoula. I've opened a quick design PR for this branch. Once that gets merged in, this looks good from my perspective. Approving now so I don't hold you up further. Thanks!
Suggested Resizable Button Changes
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
jloleysens
left a comment
There was a problem hiding this comment.
Did not test locally, but code changes LGTM
Summary
Part of #136950
Make the custom resizable button to look and feel like the EUIResizableButton (not exported by EUI).