elastic-agent manifests: align with elastic-agent repo; add comments#136394
Merged
tetianakravchenko merged 7 commits intoelastic:mainfrom Jul 25, 2022
Merged
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
6 tasks
| - rolebindings | ||
| - roles | ||
| verbs: ["get", "list", "watch"] | ||
| - apiGroups: ["networking.k8s.io"] |
Contributor
Author
There was a problem hiding this comment.
this wasn't added to the corresponding PR in elastic-agent repo - elastic/elastic-agent#381, was removed before merging elastic/elastic-agent@30b3291
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
7662548 to
c5e529a
Compare
gizas
approved these changes
Jul 21, 2022
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Jul 21, 2022
MichaelKatsoulis
approved these changes
Jul 22, 2022
Contributor
|
Before merging align with elastic/elastic-agent#708 (comment) |
…/kibana into elastic-agent-comments
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co
Summary
Align elastic-agent manifests with the elastic-agent repo: https://github.com/elastic/elastic-agent/blob/main/deploy/kubernetes/elastic-agent-managed-kubernetes.yaml for managed elastic-agent and standalone https://github.com/elastic/elastic-agent/blob/main/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml.
This PR also includes changes in PR - elastic/elastic-agent#708. should be merged before this PR.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers