Skip to content

Discover adhoc dataview#135770

Closed
kertal wants to merge 11 commits intoelastic:mainfrom
kertal:discover-adhoc-dataview
Closed

Discover adhoc dataview#135770
kertal wants to merge 11 commits intoelastic:mainfrom
kertal:discover-adhoc-dataview

Conversation

@kertal
Copy link
Copy Markdown
Member

@kertal kertal commented Jul 6, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kertal kertal mentioned this pull request Jul 7, 2022
Merged
3 tasks
@kertal kertal self-assigned this Jul 7, 2022
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Jul 7, 2022
@flash1293 flash1293 mentioned this pull request Jul 8, 2022
Closed
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 13, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState add sorting by timefield when switching from an index pattern without timefield to an indexpattern with timefield
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState keep sorting by timefield when switching between index patterns with different timeFields
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState remove sorting by timefield when switching to an index pattern without timefield that contains the timefield column
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState removing fields that are not part of the next index pattern, keeping unknown fields
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState removing sorted by fields not available in the next index pattern without modifying columns
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState removing sorted by fields that are not part of the next index pattern
  • [job] [logs] Jest Tests #5 / Discover getSwitchIndexPatternAppState should change sorting for similar index patterns
  • [job] [logs] FTR Configs #26 / Getting Started old charts library "after all" hook in "old charts library"
  • [job] [logs] FTR Configs #26 / Getting Started old charts library Shakespeare "after all" hook for "should change the Y-Axis extents"
  • [job] [logs] FTR Configs #26 / Getting Started old charts library Shakespeare "before all" hook for "should create shakespeare index pattern"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 491.9KB 492.4KB +517.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 7 6 -1
securitySolution 75 74 -1
total -3

ESLint disabled line counts

id before after diff
apm 87 84 -3
enterpriseSearch 9 7 -2
observability 49 48 -1
synthetics 61 55 -6
ux 11 10 -1
total -13

Total ESLint disabled count

id before after diff
apm 101 97 -4
enterpriseSearch 9 7 -2
observability 56 54 -2
securitySolution 514 513 -1
synthetics 67 61 -6
ux 14 13 -1
total -16

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@ppisljar
Copy link
Copy Markdown
Contributor

ppisljar commented Jul 13, 2022

i did some changes here #136266
mainly not putting the spec on discover state but rather keep working with id. the dataviews.create should only be called when loading the dataview from saved search, searchsource handles that as well, so no calls to dataviews.create should be needed from discover (maybe from locator ?)

@nreese nreese mentioned this pull request Aug 4, 2022
Closed
@kertal
Copy link
Copy Markdown
Member Author

kertal commented Sep 6, 2022

closing since it was just for evaluation

@kertal kertal closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kertal kertal

Labels

Feature:Discover Discover Application Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kertal @kibana-ci @ppisljar @kibanamachine