Skip to content

[Fleet] Add threat_intel category#135758

Merged
jen-huang merged 5 commits intoelastic:mainfrom
jen-huang:fix/new-category
Jul 11, 2022
Merged

[Fleet] Add threat_intel category#135758
jen-huang merged 5 commits intoelastic:mainfrom
jen-huang:fix/new-category

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang commented Jul 5, 2022

Summary

Resolves #135525. This PR adds code to support typing of a new category, threat_intel. This is mostly for code consistency, functionally the PR does not do anything besides allow custom integrations to be registered to the new category.

It is not expected for the UI to display this category yet until a real package using it is served from the registry.

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 5, 2022
@jen-huang jen-huang requested a review from a team as a code owner July 5, 2022 22:29
@jen-huang jen-huang self-assigned this Jul 5, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 5, 2022

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 6, 2022

@elasticmachine merge upstream

mtojek
mtojek reviewed Jul 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should drop all package category labels from Kibana and leave package-less ones only? EPR should be the only source of truth here.

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 6, 2022

@mtojek I didn't unravel the logic too closely, but from what I saw the UI is displaying the ones from the registry whenever possible. The hardcoded ones are part of fallback logic related to registering custom integrations.

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 6, 2022

@elasticmachine merge upstream

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 7, 2022

@elasticmachine merge upstream

juliaElastic
juliaElastic approved these changes Jul 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet change LGTM

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 11, 2022

@elasticmachine merge upstream

@jen-huang jen-huang enabled auto-merge (squash) July 11, 2022 18:54
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 11, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / Spaces app Spaces Search spaces in popover search for "ce-1 name" and find one space

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
customIntegrations 82 83 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
customIntegrations 6.2KB 6.2KB +35.0B
Unknown metric groups

API count

id before after diff
customIntegrations 101 102 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 7051a61 into elastic:main Jul 11, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 11, 2022
@jen-huang jen-huang deleted the fix/new-category branch July 11, 2022 20:12
This was referenced Jul 12, 2022
Merged
Merged
@jen-huang jen-huang mentioned this pull request Sep 26, 2022
Closed
5 tasks
@jen-huang jen-huang mentioned this pull request Apr 13, 2023
Closed
8 tasks
@mrodm mrodm mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

+1 more reviewer

@mtojek mtojek mtojek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jen-huang jen-huang

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fleet] Add support for threat_intel category

6 participants

@jen-huang @elasticmachine @kibana-ci @mtojek @juliaElastic @kibanamachine