Skip to content

[8.3] [Security][RAM] Fix Cases > Alerts data grid height rendering in as 0 (#134268)#134498

Merged
kibanamachine merged 1 commit into8.3from
backport/8.3/pr-134268
Jun 15, 2022
Merged

[8.3] [Security][RAM] Fix Cases > Alerts data grid height rendering in as 0 (#134268)#134498
kibanamachine merged 1 commit into8.3from
backport/8.3/pr-134268

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Jun 15, 2022

Backport

This will backport the following commits from main to 8.3:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
[Security][RAM] Fix Cases > Alerts data grid height rendering in as 0 (…
c4379a4 
…#134268)

* Fix negative rowCount causing incorrect EuiDataGrid height calculations

`alertsCount` is -1 on init which leads to buggy data grid height calculations. Waiting for `alertsCount` to be an actual value before instantiating the grid solves the issue

* Re-add fontSize styling which was causing grid height bugs in #133691 (comment)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a943b81)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 15, 2022
@kibanamachine kibanamachine enabled auto-merge (squash) June 15, 2022 16:57
@kibanamachine kibanamachine mentioned this pull request Jun 15, 2022
Merged
1 task
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 15, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 831.7KB 831.6KB -134.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit c4ec6d7 into 8.3 Jun 15, 2022
@kibanamachine kibanamachine deleted the backport/8.3/pr-134268 branch June 15, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cee-chen cee-chen

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @kibana-ci @cee-chen