Skip to content

[Fleet] Fixing wrong validation message displayed [Closes#131227]#132029

Merged
kpollich merged 3 commits intoelastic:mainfrom
PopoPilote90:main
May 11, 2022
Merged

[Fleet] Fixing wrong validation message displayed [Closes#131227]#132029
kpollich merged 3 commits intoelastic:mainfrom
PopoPilote90:main

Conversation

@PopoPilote90
Copy link
Copy Markdown
Contributor

* Condition added in function validateLogstashHosts in the try catch
* [Fleet]: Wrong validation message is displayed when host field is left empty while adding new output. elastic#131227
Co-authored-by: Pernot Nicolas nicolasn.pernot1@gmail.com
@PopoPilote90 PopoPilote90 requested a review from a team as a code owner May 11, 2022 13:24
@kibanamachine
Copy link
Copy Markdown
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 11, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich added v8.3.0 release_note:skip Skip the PR/issue when compiling release notes labels May 11, 2022
@kpollich kpollich self-assigned this May 11, 2022
@kpollich
Copy link
Copy Markdown
Member

buildkite build this

@kpollich
Copy link
Copy Markdown
Member

@elasticmachine run elasticsearch-ci/docs

Copy link
Copy Markdown
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-opening this @PopoPilote90. Once the CI build finishes this should be good to go.

I do think there might be an issue with the added translation. You may need to run the following to generate some of our auto-translated i18n values.

$ node scripts/i18n_check.js --fix

You might want to run this on your local branch anyway and see if the script makes any updates to the translation files, then push those up. I can keep an eye on that and trigger an additional CI build as needed.

Thanks again!

@PopoPilote90
Copy link
Copy Markdown
Contributor Author

@kpollich after running : node scripts/i18n_check.js --fix, there were no changes in the translation files

@kpollich
Copy link
Copy Markdown
Member

kpollich commented May 11, 2022

@PopoPilote90 I just pushed up d922ea8 to fix the lint error reported by CI.

In the future, file PR's from a branch on your fork - not the main branch of your fork. This will make things a little easier, and will allow CI to auto-commit lint failures like this instead of erroring as we did here:

[PopoPilote90/main ae741637f828] [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
--
  | 1 file changed, 14 insertions(+), 15 deletions(-)
  | fatal: The upstream branch of your current branch does not match
  | the name of your current branch.  To push to the upstream branch
  | on the remote, use
  |  
  | git push https://github.com/PopoPilote90/kibana.git HEAD:main
  |  
  | To push to the branch of the same name on the remote, use
  |  
  | git push https://github.com/PopoPilote90/kibana.git HEAD
  |  
  | To choose either option permanently, see push.default in 'git help config'.

I'd also recommend setting up ESLint in your editor of choice to catch lint error likes this during development if possible. We typically recommend VS Code for development on Kibana, and run the ESLint extension.

@kpollich
Copy link
Copy Markdown
Member

@elasticmachine run elasticsearch-ci/docs

@kpollich
Copy link
Copy Markdown
Member

buildkite test this

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 704.4KB 704.6KB +153.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants