[Fleet] Fixing wrong validation message displayed [Closes#131227]#132029
[Fleet] Fixing wrong validation message displayed [Closes#131227]#132029kpollich merged 3 commits intoelastic:mainfrom
Conversation
* Condition added in function validateLogstashHosts in the try catch * [Fleet]: Wrong validation message is displayed when host field is left empty while adding new output. elastic#131227 Co-authored-by: Pernot Nicolas nicolasn.pernot1@gmail.com
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Pinging @elastic/fleet (Team:Fleet) |
|
buildkite build this |
|
@elasticmachine run elasticsearch-ci/docs |
kpollich
left a comment
There was a problem hiding this comment.
Thanks for re-opening this @PopoPilote90. Once the CI build finishes this should be good to go.
I do think there might be an issue with the added translation. You may need to run the following to generate some of our auto-translated i18n values.
$ node scripts/i18n_check.js --fix
You might want to run this on your local branch anyway and see if the script makes any updates to the translation files, then push those up. I can keep an eye on that and trigger an additional CI build as needed.
Thanks again!
|
@kpollich after running : node scripts/i18n_check.js --fix, there were no changes in the translation files |
|
@PopoPilote90 I just pushed up d922ea8 to fix the lint error reported by CI. In the future, file PR's from a branch on your fork - not the I'd also recommend setting up ESLint in your editor of choice to catch lint error likes this during development if possible. We typically recommend VS Code for development on Kibana, and run the ESLint extension. |
|
@elasticmachine run elasticsearch-ci/docs |
|
buildkite test this |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kpollich |
Co-authored-by: Pernot Nicolas nicolasn.pernot1@gmail.com