[6.x] Remove try/catch for short url so the appropriate errors will be prop…#13179
Merged
stacey-gammon merged 1 commit intoelastic:6.xfrom Jul 28, 2017
Merged
Conversation
…agated to the UI (elastic#13004) * Remove try/catch for short url so the appropriate errors will be propagated to the UI * Simply ensure the error is a Boom error by wrapping it, but keep the original error details. * Boom.wrap can't handle non Error instances, as exist in some of the tests. * Only support Error objects, and check both status and statusCode * fix test * Fix test errors for reals this time * Break out status and statusCode short url error tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…agated to the UI (#13004)
Remove try/catch for short url so the appropriate errors will be propagated to the UI
Simply ensure the error is a Boom error by wrapping it, but keep the original error details.
Boom.wrap can't handle non Error instances, as exist in some of the tests.
Only support Error objects, and check both status and statusCode
fix test
Fix test errors for reals this time
Break out status and statusCode short url error tests