[eslint] add rule for auto-fixing unused imports#131772
Merged
spalger merged 10 commits intoelastic:mainfrom May 11, 2022
Merged
[eslint] add rule for auto-fixing unused imports#131772spalger merged 10 commits intoelastic:mainfrom
spalger merged 10 commits intoelastic:mainfrom
Conversation
9066cab to
9aede39
Compare
9aede39 to
5401cbf
Compare
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
mattkime
approved these changes
May 7, 2022
Contributor
mattkime
left a comment
There was a problem hiding this comment.
app services changes lgtm
nreese
approved these changes
May 9, 2022
Contributor
nreese
left a comment
There was a problem hiding this comment.
kibana-gis changes LGTM
code review
jbudz
approved these changes
May 9, 2022
zizhouW
approved these changes
May 9, 2022
zizhouW
left a comment
There was a problem hiding this comment.
Session view changes LGTM! Thanks for doing it!
drewdaemon
reviewed
May 9, 2022
sabarasaba
approved these changes
May 10, 2022
Member
sabarasaba
left a comment
There was a problem hiding this comment.
Changes lgtm, left two small comments about some comments that I think we can also remove
x-pack/plugins/index_management/__jest__/components/index_table.test.js
Outdated
Show resolved
Hide resolved
...s/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js
Outdated
Show resolved
Hide resolved
YulNaumenko
approved these changes
May 11, 2022
Contributor
YulNaumenko
left a comment
There was a problem hiding this comment.
Security Solution changes LGTM
ashokaditya
approved these changes
May 11, 2022
Member
ashokaditya
left a comment
There was a problem hiding this comment.
security_solution changes are good to go.
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
smith
approved these changes
May 11, 2022
ThomThomson
approved these changes
May 11, 2022
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team changes LGTM! Lots of unused imports to be removed, thanks!
dasansol92
approved these changes
May 11, 2022
Contributor
dasansol92
left a comment
There was a problem hiding this comment.
security_solution LGTM! Thanks for doing this cleaning!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107233
Adds an ESLint rule that removes unused imports in CI and in the precommit hook. When run in editors a warning is logged and a suggestion is provided, but auto-fix is disabled to prevent ESLint ripping out imports when code is temporary removed.