Add unit tests the verify correct dataType in jQuery.ajax request when loading Console app state.#13092
Merged
azasypkin merged 1 commit intoelastic:masterfrom Jul 27, 2017
Conversation
azasypkin
commented
Jul 25, 2017
Contributor
Author
There was a problem hiding this comment.
note: it's a bit weird that it's called twice (not sure if it's a bug or not), but here is how it works :)
Contributor
Author
|
jenkins, test this |
Member
|
Try merging master into your branch |
… when loading Console app state.
1937896 to
85b882d
Compare
Contributor
Author
Done, build is green now. By the way is there any reason why we don't want to use let's say |
Member
|
I wouldn't be opposed to using the mocha reporter if it added value. |
Contributor
Author
Ok, I'll add it to my TODO list then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure we're safe with
jQuery 2.2.4and https://nodesecurity.io/advisories/328.Tests are written in a "new style" (not
QUnit) so that we can run them on CI.