Skip to content

[XY] xyVis split chart.#130229

Merged
Kuznietsov merged 224 commits intoelastic:mainfrom
Kuznietsov:chart_expressions_xy-split_chart
May 11, 2022
Merged

[XY] xyVis split chart.#130229
Kuznietsov merged 224 commits intoelastic:mainfrom
Kuznietsov:chart_expressions_xy-split_chart

Conversation

@Kuznietsov
Copy link
Copy Markdown
Contributor

@Kuznietsov Kuznietsov commented Apr 14, 2022

Summary

Completes part of #127115
Added splitColumnAccessor and splitRowAccessor to the xyVis expression.

Multiple dataLayers

Screenshot 2022-04-14 at 12 17 37

splitRowAccessor is specified

Screenshot 2022-04-14 at 12 18 10

splitColumnAccessor is specified

Screenshot 2022-04-14 at 12 18 42

splitRowAccessor and splitColumnAccessor are specified

Screenshot 2022-04-14 at 12 18 30

Kuznietsov and others added 30 commits March 8, 2022 16:08
@Kuznietsov
added xy plugin.
9388bba
@kibanamachine
Merge branch 'main' into chart_expressions-xy
8df9659
@Kuznietsov
Added expressionXY limits.
ab72728
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
5747322 
…to chart_expressions-xy
@Kuznietsov
Added xy expression functions to the expression_xy plugin.
b4ee9c1
@Kuznietsov
Moved xy to a separate plugin.
400845d
@Kuznietsov
Small refactoring.
b2090f3
@Kuznietsov
Fixed types.
33a06fa
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
d94fa4f 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.tsx
@Kuznietsov
Fixed import of scss.
663e093
@Kuznietsov
Fixed imports.
cbffe77
@Kuznietsov
Added required plugins.
389f933
@Kuznietsov
Fixed import
90aa97a
@Kuznietsov
Fixed types.
1d3a264
@Kuznietsov
Changed expression names.
a78d45d
@Kuznietsov
Fixed bugs, caused by the refactoring process.
35cab91
@kibanamachine
Merge branch 'main' into chart_expressions-xy
847b3c4
@Kuznietsov
Fixed lens snapshots.
ed7f8ea
@Kuznietsov
Removed new line.
b6daa5d
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
bda6524 
…to chart_expressions-xy
@Kuznietsov
Fixed xy_chart tests.
c8d40fe
@Kuznietsov
Added lazy loading for xy chart.
5fed60c
@Kuznietsov
Fixed xy chart test.
dc195b2
@Kuznietsov
Fixed broken chart selectors.
d39681f
@Kuznietsov
Fixed dashboard tests.
b901d68
@Kuznietsov
dashboard test fixed.
d327dfe
@Kuznietsov
Fixed heatmap vis.
b500961
@Kuznietsov
Smokescreen test fixed.
7a25b74
@Kuznietsov
more fixes.
0004794
@Kuznietsov
async dashboard tests fixed.
fc8c0b3
kibanamachine and others added 13 commits May 2, 2022 04:08
@kibanamachine
Merge branch 'main' into chart_expressions-xy-extended_layers
59ee004
@mbondyra
Merge commit '27d1fa1797b21a975173e89e9d65a2d029b64304' into chart_ex…
b516bb3 
…pressions-xy-extended_layers

# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/annotation_layer.ts
#	src/plugins/chart_expressions/expression_xy/public/components/annotations.tsx
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
#	src/plugins/event_annotation/common/index.ts
#	src/plugins/event_annotation/common/manual_event_annotation/index.ts
#	src/plugins/event_annotation/common/types.ts
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/annotations_config_panel/index.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/color_picker.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/reference_line_config_panel/reference_line_panel.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/icon_select.tsx
#	x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/marker_decoration_settings.tsx
@mbondyra
xy_chart.test types
c4b7119
@mbondyra
icon type
76c3c78
@Kuznietsov
Merge branch 'main' into chart_expressions-xy-extended_layers
b41f51d 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
@Kuznietsov
Removed not used check.
2906aef
@Kuznietsov
Merge branch 'chart_expressions-xy-extended_layers' into chart_expres…
8384019 
…sions_xy-split_chart

# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
@Kuznietsov
Replaced an with the.
0f4835f
@Kuznietsov
Merge branch 'chart_expressions-xy-extended_layers' into chart_expres…
cf6574b 
…sions_xy-split_chart
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
773ec7f 
…-fix'
@Kuznietsov
Fixed tests.
c407547
@Kuznietsov
Merge branch 'chart_expressions-xy-extended_layers' into chart_expres…
a135c6e 
…sions_xy-split_chart
@Kuznietsov
Merge branch 'main' into chart_expressions_xy-split_chart
b3583b2 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts
#	src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx
#	src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
@Kuznietsov Kuznietsov added the WIP Work in progress label May 6, 2022
Kuznietsov added 3 commits May 10, 2022 11:52
@Kuznietsov
Merge branch 'main' into chart_expressions_xy-split_chart
ccf1ec4 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts
@Kuznietsov
Added tests for the splitChart.
47f2202
@Kuznietsov
Added snapshots for errors.
e37ce12
@Kuznietsov Kuznietsov requested a review from crob611 May 10, 2022 11:57
@Kuznietsov Kuznietsov marked this pull request as ready for review May 10, 2022 11:57
@Kuznietsov Kuznietsov requested a review from a team as a code owner May 10, 2022 11:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 10, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov
Merge branch 'main' into chart_expressions_xy-split_chart
af76fb8 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx
Kuznietsov added 3 commits May 11, 2022 16:01
@Kuznietsov
Fixed sorting of GroupBy.
9c48642
@Kuznietsov
Merge branch 'main' into chart_expressions_xy-split_chart
d0d3b37 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts
@Kuznietsov
Updated snapshot
71d2a00
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 11, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionXY 90 91 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionXY 122 124 +2
lens 449 451 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 55.5KB 56.4KB +968.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY 28.6KB 29.1KB +505.0B
Unknown metric groups

API count

id before after diff
expressionXY 132 134 +2
lens 524 526 +2
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

flash1293
flash1293 approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense, LGTM for now

@Kuznietsov Kuznietsov merged commit 6527391 into elastic:main May 11, 2022
@Kuznietsov Kuznietsov removed the WIP Work in progress label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@crob611 crob611 Awaiting requested review from crob611

Assignees

@Kuznietsov Kuznietsov

Labels

backport:skip This PR does not require backporting impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:VisEditors release_note:feature Makes this part of the condensed release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kuznietsov @elasticmachine @kibana-ci @flash1293 @kibanamachine @mbondyra