Children of buttons won't capture hover events in firefox#13015
Conversation
snide
left a comment
There was a problem hiding this comment.
Just need to adjust the accessibility stuff.
| <dashboard-app class="app-container dashboard-container"> | ||
| <div class="fullScreenModePlaceholder"> | ||
| <button | ||
| <div |
There was a problem hiding this comment.
This will now need a tab index and aria label.
There was a problem hiding this comment.
used kbn-accessible-click, that seemed to work better, otherwise I couldn't seem to press "enter" once it was highlighted.
There was a problem hiding this comment.
👍 Good thinking @snide. kbn-accessible-click adds those properties under the hood, so good call @stacey-gammon.
| @@ -10,7 +10,7 @@ | |||
| Exit full screen | |||
| <span aria-hidden="true" class="kuiIcon fa fa-angle-left"></span> | |||
There was a problem hiding this comment.
You can remove the aria labels here now.
…irefox-fullscreen-hover-button
cjcenizal
left a comment
There was a problem hiding this comment.
Awesome! I love the attention to detail wrt adding extra info via the aria-label. It might be worth checking this with @aphelionz to make sure it actually adds the value we think it does, though.
Fixes #12987
cc @cjcenizal