@ghudgins Do you think the upsides are worth the downsides?

@elasticmachine merge upstream

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@elasticmachine merge upstream

@MichaelMarcialis Aside the copy, it's a bit annoying to have a new setting that visible in the sidebar which is not relevant in a lot of cases. Do you have another idea how to handle it?

@MichaelMarcialis Aside the copy, it's a bit annoying to have a new setting that visible in the sidebar which is not relevant in a lot of cases. Do you have another idea how to handle it?

If we're confident that the majority of cases would not need/desire to use such a setting, then moving under advanced options (as @mbondyra mentions above) makes sense to avoid adding another ever-present item to the form.

Another thought might be whether or not such a setting needs to be managed at the individual dimension configuration level, or if it can/should be managed globally for all relevant dimensions in the visualization. If there is a desire to explore a global-level setting, it could be moved out of the configuration flyouts entirely and placed in one of the toolbar menus (perhaps under appearance).

Thanks for the feedback, what about this:

I really like this approach, feels much better than the previous one!

If there is a desire to explore a global-level setting, it could be moved out of the configuration flyouts entirely and placed in one of the toolbar menus (perhaps under appearance).

It feels like this setting should be close to the metric it is affecting

Thanks for the feedback, what about this:

I really like this approach, feels much better than the previous one!

While this works technically, the issue I have with this approach is that it's inconsistent with the rest of the advanced settings presented. Interacting with the other advanced settings options renders a new form input to the configuration flyout. This would be the only advanced setting that doesn't do that in this particular configuration flyout.

Personally, I'm still of the mindset that these advanced settings should be placed a simple advanced settings accordion in the flyout, rather than a popover menu whose options trigger the rendering of new advanced setting inputs individually. I know we've put some advanced settings in an accordion in some configuration flyouts, but we still need to transition to that approach in places such as this. If we don't have the time/scope to make such a change here, we can either go with your approach here or have the option render a new EuiSwitch component to the flyout when clicked (to keep consistent with the rest of the menu interactions).

@MichaelMarcialis what about this?

If we don't have the time/scope to make such a change here, we can either go with your approach here or have the option render a new EuiSwitch component to the flyout when clicked (to keep consistent with the rest of the menu interactions).

I would like to do that separately, I put it on the agenda for 8.3

we can either go with your approach here or have the option render a new EuiSwitch component to the flyout when clicked

It felt weird to me because the switch would either disappear on disabling the setting or it would stick around forever after being added once which is both slightly unexpected to me.

@MichaelMarcialis what about this?

That works for the interim, until we take the accordion approach. Not super keen about the switch throwing off the text alignment, but not sure moving the switch to the right side would look much better.

💚 Build Succeeded

• Buildkite Build
• Commit: c475e6b
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

History

• 💚 Build #32572 succeeded 991b905
• 💚 Build #32112 succeeded d94f0bb
• 💚 Build #31323 succeeded 35dafc5
• 💔 Build #30608 failed e16c324
• 💔 Build #30559 failed 17bcf1d
• 💔 Build #30382 failed f47a27a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream