new response handlers for vislib#12661
Closed
ppisljar wants to merge 9 commits intoelastic:masterfrom
Closed
Conversation
20bf21c to
033806a
Compare
033806a to
6fc6a41
Compare
93e70dd to
cbaa7a3
Compare
cbaa7a3 to
f301fe3
Compare
c2bd94a to
3c66c4e
Compare
Contributor
Contributor
nreese
reviewed
Jul 27, 2017
Contributor
There was a problem hiding this comment.
As long as you are updating all of the fixtures, how about exporting a named object instead of default?
Contributor
There was a problem hiding this comment.
Update comment for hierarchical response
This was referenced Jul 28, 2017
43677da to
c53dead
Compare
ppisljar
commented
Jul 31, 2017
Contributor
Author
There was a problem hiding this comment.
this should probably be {{y}} or similar
c53dead to
b5c75b3
Compare
b5c75b3 to
9087ac4
Compare
Contributor
Author
|
closing, will reimplement but based on tabify resposne not es response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


two response handlers:
goals:
as side effect two issues are fixed:
closes #12746
closes #10543
things that are still missing:
other charts should be converted to use one of the new request handlers as well, probably the third one will need to be added (table_data)
using visualizations is now fairly easy as the data object is no longer coupled to elastic search.