[Lens] Switch to unified metric renderer#126019
Conversation
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
…to_unified_metric_renderer
…to_unified_metric_renderer
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
left a comment
There was a problem hiding this comment.
Most of this works perfectly fine, there's just one thing I noticed about the font sizes (see comment)
| reverse: false, | ||
| }; | ||
|
|
||
| const fontSizes: Record<string, { size: number; sizeUnit: string }> = { |
There was a problem hiding this comment.
It seems like this mapping is pretty different than the old one: https://github.com/elastic/kibana/pull/126019/files#diff-2c977ca1fa0b45f15d61f5c8722ef7209c1e01f521a69761454599b074203778L37-L85
I don't have a super strong opinion on this but especially the small sizes feel too large with this new setting - it's very useful to create small metrics, e.g. for solutions (left is new, right is old).
I would suggest going with the old mapping
There was a problem hiding this comment.
@flash1293 I tried to find a general approach so that the ratio of the size of the metric to the size of the labels is always the same, because before each metric size was chosen according to different rules depending on the size of the label. You can see it here x-pack/plugins/lens/public/metric_visualization/expression.scss
If you would like I can back to that solution and update mapping
There was a problem hiding this comment.
I promised to have a look here and I just wanted to confirm that Joe's solution will be ok from my point of view!
|
@elasticmachine merge upstream |
…b.com:VladLasitsa/kibana into switch_lens_metric_to_unified_metric_renderer
flash1293
left a comment
There was a problem hiding this comment.
Small nit, approving to not holding back merging this
|
@elasticmachine merge upstream |
…to_unified_metric_renderer
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Closes: #123797
Summary
toExpressionfunction so that build correctmetricVisexpression.