[MetricVis] Add auto scale functionality to metric unified renderer#124811
[MetricVis] Add auto scale functionality to metric unified renderer#124811VladLasitsa merged 13 commits intoelastic:mainfrom
Conversation
|
@flash1293 As new HOC component: |
|
@VladLasitsa Not for now, if a use case comes up we are going to move it into a shared space. |
|
@elasticmachine merge upstream |
Kuznietsov
left a comment
There was a problem hiding this comment.
@VladLasitsa, thanks. Code LGTM 👍
Please, address one comment.
src/plugins/chart_expressions/expression_metric/public/components/with_auto_scale.test.tsx
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
left a comment
There was a problem hiding this comment.
Not sure about some stylings, but LGTM otherwise.
| // mtrChart__legend-isLoading | ||
|
|
||
| .mtrVis { | ||
| @include euiScrollBar; |
There was a problem hiding this comment.
Why do we need these changes? I don't notice any difference
There was a problem hiding this comment.
Because we use VisualizationContainer here with styles which includes styles for scrollbar, but styles of VisualizationContainer loaded only when we open visualization first (because we load styles here src\plugins\visualizations\public\vis_async.ts). If we open metric directly in canvas you will see so that we don't have scroll at all because we don't load styles for VisualizationContainer. So to be sure that we will have correct scroll I added these styles here.
|
@elasticmachine merge upstream |
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Left one small comment, but otherwise approved. Thanks!
src/plugins/chart_expressions/expression_metric/public/components/with_auto_scale.styles.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Part of: #123797
Summary
autoScalearg to metric expression which enable auto scalingAutoScalecomponent to support auto scale functionality for metric unified rendererHow it looks on dashboard:
