[UI Framework] Define consistent default, small, and wide sizing for form fields, and support them within ExpressionItems.#12190
Conversation
snide
left a comment
There was a problem hiding this comment.
Might want to check a couple places that might need the fluid width stuff in Kibana. Otherwise the code looks ok to me.
Comments otherwise are minor. LGTM.
There was a problem hiding this comment.
Might want to follow a pattern with your sizes.
$globalFormFieldSmallWidth: $globalFormFieldDefaultWidth / 3;
$globalFormFieldLargeWidth: $globalFormFieldDefaultWidth * 2;
...etc. Just some sort of math so that when they sit next to each other they look like they were planned.
There was a problem hiding this comment.
I like the idea of applying some rhythms that make sense, but as it is they're just chosen because they look good in different scenarios. Can we get together at some point and figure out a rhythm that we can apply here so the values aren't so arbitrary?
|
That bug you found with the Watcher table is actually a problem with their markup. I'll address that in another issue. |
|
@snide I looked through through the UI and didn't find anything weird. Can you take another look and approve the PR? |
…d support them within ExpressionItems.
35b0236 to
737e456
Compare
@BigFunger This should fix the problem you've been having with putting different sizes of inputs into an expression.