[Reporting] remove legacy pdf shim#121369
Conversation
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
| objects: relativeUrls.map((u) => ({ relativeUrl: u })), | ||
| // return the payload | ||
| return { | ||
| ...jobParams, |
There was a problem hiding this comment.
I noticed this should have isDeprecated: true since we have a V2 type for this. I'm leaving that as a separate issue: #121365
| "max_attempts": undefined, | ||
| "meta": Object { | ||
| "isDeprecated": false, | ||
| "isDeprecated": undefined, |
There was a problem hiding this comment.
This is not exactly correct (should be true since there is a V2 type), but is related to #121365
| import * as GenerationUrls from '../services/generation_urls'; | ||
| import { ReportingUsageStats } from '../services/usage'; | ||
|
|
||
| // These all have the domain name portion stripped out. The api infrastructure assumes it when we post to it anyhow. |
There was a problem hiding this comment.
Review note: Now that the shim is removed, this URLs are only used in this file, so I removed the entire GenerationUrls service to inline the URLs in this file.
vadimkibana
left a comment
There was a problem hiding this comment.
Core review only, LGTM.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Closes #120192
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note:
Breaking change: POST URLs generated for PDF reports in Kibana 6.2 will no longer work. Please regenerate the POST URLs that you need for automating reports.