WIP: Create Countdown React vis type#11984
Closed
cjcenizal wants to merge 73 commits intoelastic:feature/visualizefrom
Closed
WIP: Create Countdown React vis type#11984cjcenizal wants to merge 73 commits intoelastic:feature/visualizefrom
cjcenizal wants to merge 73 commits intoelastic:feature/visualizefrom
Conversation
(cherry picked from commit d11cef1)
Contributor
Author
|
@ppisljar @thomasneirynck Any idea why I'm getting |
43a9d6e to
6774d5d
Compare
Contributor
|
is this recently rebased ? (like .... 3 hours ago) |
Contributor
Author
|
@ppisljar Yep, rebased 20 mins ago |
Merged
Contributor
|
visData is undefined because your response_handler resolves() with no parameters ... you should pass a data parameter to it (at least resolve(true) then your visData will be true and will indicate that your visualization is data dependent. vis was null due to a bug in react_vis_types which is now fixed (pls rebase) |
0e3d49f to
8f9f1db
Compare
63e1421 to
abf0a6d
Compare
0786437 to
f844475
Compare
20bf21c to
033806a
Compare
033806a to
6fc6a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.