Skip to content

[8.0] [Reporting] Add link to Kibana app from Reporting management UI + Design update (#111412)#118524

Merged
jloleysens merged 1 commit intoelastic:8.0from
jloleysens:backport/8.0/pr-111412
Nov 15, 2021
Merged

[8.0] [Reporting] Add link to Kibana app from Reporting management UI + Design update (#111412)#118524
jloleysens merged 1 commit intoelastic:8.0from
jloleysens:backport/8.0/pr-111412

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 8.0:

…ign update (elastic#111412)

* moved components to nested components dir

* added health status indicator

* download button -> download link

* updated poblic Job API, remove some of the "rendering" behaviour

* restructure list table contents and clean up use of i18n

* set table column widths

* slight update to table column widths

* actually use action width 🤦

* added view in app link component and included space id in public side Job

* server side changes so that we can get the job payload containing the locator

* initial round of public-side changes to make the link to Kibana app work

* added tooltip to view action

* remove unused import and do not show chrome

* removed use of fp-ts

* added type column and updated mobile look

* remove unused imports

* take a different approach to job query factory -> added new function called "getReport" and leave "get" as is

* update i18n

* code simplifications, also ensure that "PROCESSING" status is being handled by health indicator

* do not hide chrome

* refactor jest test:
 - make test more specific and remove snapshot
 - added use of isMounted() to not run set state when component
   is not mounted

* surface deprecation warning in a special way

* updated one functional test

* updated other functional test

* Several updates to bring table more in line with design
 * Removed "created by" column
 * Added app icons instead of names
 * Added content type indication (PDF, CSV or PNG)
 * Updated the "info" button to have no colors
 * Updated the status to have a timestamp and show "yellow" if
   we detect any issues and guide users to view the report info.

* a lot of changes to bring this more in line with defazio designs

* fix lint

* -wip- [skip-ci]

* some very basic house keeping [skip-ci]

* get to a point where the linking behaviour is working as expected

* further house-keeping, remove unecessary components

* clean up imports

* move hasIssues check into status indicator

* refactored report status indicator

* hide open kibana app button when not available

* remove unused import

* fix jest tests

* created a new redirect plugin to avoid page flicker

* remove unused report info button

* removed unused translations

* fix jest tests after changing the redirect app path

* added reportingRedirect to applicationUsageSchema

* added column width for type

* update test for extracting first row title

* update functional test snapshot

* updated plugins schema

* removed the interstitial page so that we do not conflict with future work planned for the share service

* remove unused i18n

* small, but center-ish type icons

* elastic@ email address

* add i18n, update import with forward slash and added missing ":" to TODO

* move non-type export to own import line and "type" to only-type imports

* remove unecessary export

* refactor payload endpoint to locatorParams endpoint and document query function

* finish refactoring client side to work with new locatorParams endpoint

* remove unused import

* use info endpoint because it contains payload!

* added functional test to ensure that we can navigate back to report

* added jest test for checking that link navigated to is spaces aware

* fix type issue and remove unused import

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jloleysens jloleysens added the backport This PR is a backport of another PR label Nov 15, 2021
@jloleysens jloleysens enabled auto-merge (squash) November 15, 2021 13:20
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
reporting 68 83 +15

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
reporting 160 162 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 45.5KB 56.3KB +10.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 40.6KB 42.0KB +1.4KB
Unknown metric groups

API count

id before after diff
reporting 163 165 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 140db56 into elastic:8.0 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants