Skip to content

[ML] Add multilayer time axis style to Data visualizer doc count chart#117398

Merged
qn895 merged 3 commits intoelastic:mainfrom
qn895:ml-add-multilayer-time-axis-data-viz
Nov 5, 2021
Merged

[ML] Add multilayer time axis style to Data visualizer doc count chart#117398
qn895 merged 3 commits intoelastic:mainfrom
qn895:ml-add-multilayer-time-axis-data-viz

Conversation

@qn895
Copy link
Copy Markdown
Member

@qn895 qn895 commented Nov 3, 2021

Summary

This PR adds elastic-charts's new multilayer time axis style to Data visualizer doc count chart and improves the level of details the tooltip provides.

Screen Shot 2021-11-03 at 13 19 26

@qn895 qn895 self-assigned this Nov 3, 2021
@qn895 qn895 requested a review from a team as a code owner November 3, 2021 18:22
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

services: { data, uiSettings, fieldFormats },
} = useDataVisualizerKibana();

const xAxisFormatter = fieldFormats.deserialize({ id: 'date' });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, is it possible to have the time formatting the same in the tooltip and the tick labels? I wonder if they should use the default format for date fields, or even the format configured for the timestamp field in the data view?

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip uses the format configured under dateFormat in Advanced settings, so the current behavior is probably ok. Not sure if / how the top time line of the multiline axis would use that setting?

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 521.8KB 522.1KB +293.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 10.1KB 10.2KB +136.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 5, 2021
@qn895 qn895 merged commit 55d40a2 into elastic:main Nov 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 117398

@qn895 qn895 removed the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 5, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117398 or prevent reminders by adding the backport:skip label.

@qn895 qn895 added the backport:skip This PR does not require backporting label Nov 9, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@qn895 qn895 deleted the ml-add-multilayer-time-axis-data-viz branch December 21, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:enhancement v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants