Skip to content

[7.15] [Discover/Reporting] Fix export that does not contain relative time filter (#110459)#112089

Merged
jloleysens merged 1 commit intoelastic:7.15from
jloleysens:backport/7.15/pr-110459
Sep 14, 2021
Merged

[7.15] [Discover/Reporting] Fix export that does not contain relative time filter (#110459)#112089
jloleysens merged 1 commit intoelastic:7.15from
jloleysens:backport/7.15/pr-110459

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.15:

…ilter (elastic#110459)

* version 1 of fix: we set the time range on the search source at CSV generation time

* updated jest tests and updated API for getSharingData

* make time range optional for getSharingData

* pivot to updating "getTime" functionality by introducing a new flag

* update jest snapshots

* update comment

* refactored coerceToAbsoluteTime -> coerceRelativeTimeToAbsoluteTime and updated behaviour to be more specific

* fix jest test

* do not change createFilter API, rather create new createRelativeFilter API, also only use this in one place in discover

* update jest tests

* update mock

* update jest test mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/common/query/timefilter/get_time.test.ts
@jloleysens jloleysens added the backport This PR is a backport of another PR label Sep 14, 2021
@jloleysens jloleysens enabled auto-merge (squash) September 14, 2021 12:43
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 3012 3018 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 558.1KB 558.2KB +8.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 795.0KB 796.7KB +1.7KB
Unknown metric groups

API count

id before after diff
data 3529 3535 +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit d644bc4 into elastic:7.15 Sep 14, 2021
@jloleysens jloleysens deleted the backport/7.15/pr-110459 branch September 15, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants