Skip to content

[7.x] [ML] APM Latency Correlations: Code consolidation. (#110790)#111495

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-110790
Sep 8, 2021
Merged

[7.x] [ML] APM Latency Correlations: Code consolidation. (#110790)#111495
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-110790

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

Code deduplication:
- combine 3 existing client side hooks into useSearchStrategy
- combine server side multiple search strategy files into shared search_strategy_provider.ts
- Clarified naming (client/server params, strategy naming etc.), improved types.
- None of the actual deeper internal logic changed, larger chunks of code that show up as new lines is mostly just moved code + additional types (e.g. function overloads) to support the different search strategies with the same server side code and client side hook.
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 8, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) September 8, 2021 07:50
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB -9.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@kibanamachine kibanamachine merged commit 3c04a06 into elastic:7.x Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants