Merged
Conversation
Backports PR #9871 **Commit 1:** - added controller option - added $location service to determine on which the user is at currently * Original sha: ddc2eb5 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-01-13T17:29:50Z **Commit 2:** added test for the hideButton method that is dependent on the location path * Original sha: f27a535 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-01-13T23:43:14Z **Commit 3:** removed argument * Original sha: c9d5c0c * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-01-14T13:44:35Z **Commit 4:** use locals object to pass variables to the template's scope * Original sha: 07b7549 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-03-04T21:26:33Z **Commit 5:** use map object * Original sha: f9ee311 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-03-04T21:33:48Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navbarextensions improvements
Backports PR #9871
Commit 1:
Commit 2:
added test for the hideButton method that is dependent on the location path
Commit 3:
removed argument
Commit 4:
use locals object to pass variables to the template's scope
Commit 5:
use map object