[7.x] [RAC] [TGrid] Implements sorting in the TGrid (#107495)#107686
Merged
andrew-goldstein merged 1 commit intoelastic:7.xfrom Aug 4, 2021
Merged
[7.x] [RAC] [TGrid] Implements sorting in the TGrid (#107495)#107686andrew-goldstein merged 1 commit intoelastic:7.xfrom
TGrid (#107495)#107686andrew-goldstein merged 1 commit intoelastic:7.xfrom
Conversation
## Summary This PR implements sorting in the `TGrid`, per the animated gifs below:  _Above: Sorting in Observability, via `EuiDataGrid`'s sort popover_  _Above: Sorting and hiding columns in the Security Solution via `EuiDataGrid`'s column header actions_ ## Details * Sorting is disabled for non-aggregatble fields * This PR resolves the `Sort [Object Object]` TODO described [here](elastic#106199 (comment)) * ~This PR restores the column header tooltips where the TGrid is used in the Security Solution~ ## Desk testing To desk test this PR, you must enable feature flags in the Observability and Security Solution: - To desk test the `Observability > Alerts` page, add the following settings to `config/kibana.dev.yml`: ``` xpack.observability.unsafe.cases.enabled: true xpack.observability.unsafe.alertingExperience.enabled: true xpack.ruleRegistry.write.enabled: true ``` - To desk test the TGrid in the following Security Solution, edit `x-pack/plugins/security_solution/common/experimental_features.ts` and in the `allowedExperimentalValues` section set: ```typescript tGridEnabled: true, ``` cc @mdefazio
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/observability/feature_controls/observability_security·ts.ObservabilityApp feature controls observability security feature controls observability cases all privileges allows a case to be createdStandard OutStack TraceMetrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
TGrid([RAC] [TGrid] Implements sorting in theTGrid#107495)