[7.x] [FieldFormats] fix `register` on start contract (#106828) by kibanamachine · Pull Request #106994 · elastic/kibana

kibanamachine · 2021-07-28T12:08:03Z

Backports the following commits to 7.x:

[FieldFormats] fix register on start contract ([FieldFormats] fix register on start contract #106828)

kibanamachine · 2021-07-28T14:24:58Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 215df6e
Storybooks Preview
Flaky suites:
- oss-firefox

Test Failures

Kibana Pipeline / general / Firefox UI Functional Tests.test/functional/apps/discover/_field_data_with_fields_api·ts.discover app discover tab with new fields API field data the search term should be highlighted in the field data

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/103389

[00:00:00]       │
[00:08:30]         └-: discover app
[00:08:30]           └-> "before all" hook in "discover app"
[00:08:30]           └-> "before all" hook in "discover app"
[00:08:52]           └-: discover tab with new fields API
[00:08:52]             └-> "before all" hook in "discover tab with new fields API"
[00:08:52]             └-> "before all" hook in "discover tab with new fields API"
[00:08:52]               │ debg Cleaning all saved objects { space: undefined }
[00:08:52]               │ info deleting batch of 2 objects
[00:08:52]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_7.15.0_001/L6bHR3JKTLiexzROv4Y-fA] update_mapping [_doc]
[00:08:52]               │ succ deleted 2 objects
[00:08:52]               │ debg resolved import for test/functional/fixtures/kbn_archiver/discover.json to /dev/shm/workspace/parallel/1/kibana/test/functional/fixtures/kbn_archiver/discover.json
[00:08:52]               │ info importing 2 saved objects { space: undefined }
[00:08:53]               │ succ import success
[00:08:53]               │ info [test/functional/fixtures/es_archiver/logstash_functional] Loading "mappings.json"
[00:08:53]               │ info [test/functional/fixtures/es_archiver/logstash_functional] Loading "data.json.gz"
[00:08:53]               │ info [test/functional/fixtures/es_archiver/logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:08:53]               │ info [test/functional/fixtures/es_archiver/logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:08:53]               │ info [test/functional/fixtures/es_archiver/logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:08:55]               │ debg replacing kibana config doc: {"defaultIndex":"logstash-*","discover:searchFieldsFromSource":false}
[00:08:55]               │ debg applying update to kibana config: {"timepicker:timeDefaults":"{ \"from\": \"2015-09-18T06:31:44.000Z\", \"to\": \"2015-09-23T18:31:44.000Z\"}"}
[00:08:56]               │ debg navigating to discover url: http://localhost:6111/app/discover#/
[00:08:56]               │ debg navigate to: http://localhost:6111/app/discover#/
[00:08:57]               │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:08:57]               │ debg ... sleep(700) start
[00:08:57]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_7.15.0_001/L6bHR3JKTLiexzROv4Y-fA] update_mapping [_doc]
[00:08:58]               │ debg ... sleep(700) end
[00:08:58]               │ debg returned from get, calling refresh
[00:08:59]               │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:01]               │ debg currentUrl = http://localhost:6111/app/discover#/
[00:09:01]               │          appUrl = http://localhost:6111/app/discover#/
[00:09:01]               │ debg TestSubjects.find(kibanaChrome)
[00:09:01]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:02]               │ debg ... sleep(501) start
[00:09:03]               │ debg ... sleep(501) end
[00:09:03]               │ debg in navigateTo url = http://localhost:6111/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!(!(%27@timestamp%27,desc)))
[00:09:03]               │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[00:09:03]               │ debg ... sleep(501) start
[00:09:04]               │ debg ... sleep(501) end
[00:09:04]               │ debg in navigateTo url = http://localhost:6111/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!(!(%27@timestamp%27,desc)))
[00:09:04]             └-: field data
[00:09:04]               └-> "before all" hook for "search php should show the correct hit count"
[00:09:04]               └-> search php should show the correct hit count
[00:09:04]                 └-> "before each" hook: global before each for "search php should show the correct hit count"
[00:09:04]                 │ debg QueryBar.setQuery(php)
[00:09:04]                 │ debg TestSubjects.click(queryInput)
[00:09:04]                 │ debg Find.clickByCssSelector('[data-test-subj="queryInput"]') with timeout=10000
[00:09:04]                 │ debg Find.findByCssSelector('[data-test-subj="queryInput"]') with timeout=10000
[00:09:05]                 │ debg TestSubjects.getAttribute(queryInput, value, tryTimeout=120000, findTimeout=10000)
[00:09:05]                 │ debg TestSubjects.find(queryInput)
[00:09:05]                 │ debg Find.findByCssSelector('[data-test-subj="queryInput"]') with timeout=10000
[00:09:05]                 │ debg QueryBar.submitQuery
[00:09:05]                 │ debg TestSubjects.click(queryInput)
[00:09:05]                 │ debg Find.clickByCssSelector('[data-test-subj="queryInput"]') with timeout=10000
[00:09:05]                 │ debg Find.findByCssSelector('[data-test-subj="queryInput"]') with timeout=10000
[00:09:10]                 │ debg isGlobalLoadingIndicatorVisible
[00:09:10]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:10]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:10]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:14]                 │ debg isGlobalLoadingIndicatorVisible
[00:09:14]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:14]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:15]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:09:16]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:16]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:16]                 │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:09:16]                 │ debg TestSubjects.find(discoverQueryHits)
[00:09:16]                 │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:09:16]                 └- ✓ pass  (12.1s) "discover app discover tab with new fields API field data search php should show the correct hit count"
[00:09:16]               └-> the search term should be highlighted in the field data
[00:09:16]                 └-> "before each" hook: global before each for "the search term should be highlighted in the field data"
[00:09:16]                 │ debg TestSubjects.moveMouseTo(field-extension)
[00:09:16]                 │ debg TestSubjects.find(field-extension)
[00:09:16]                 │ debg Find.findByCssSelector('[data-test-subj="field-extension"]') with timeout=10000
[00:09:16]                 │ debg TestSubjects.click(fieldToggle-extension)
[00:09:16]                 │ debg Find.clickByCssSelector('[data-test-subj="fieldToggle-extension"]') with timeout=10000
[00:09:16]                 │ debg Find.findByCssSelector('[data-test-subj="fieldToggle-extension"]') with timeout=10000
[00:09:18]                 │ debg TestSubjects.find(docTable)
[00:09:18]                 │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:09:18]                 │ debg Firefox stdout: 1627476164553	Marionette	WARN	TimedPromise timed out after 500 ms: stacktrace:
[00:09:18]                 │      TimedPromise/<@chrome://marionette/content/sync.js:228:19
[00:09:18]                 │      TimedPromise@chrome://marionette/content/sync.js:213:10
[00:09:18]                 │      interaction.flushEventLoop@chrome://marionette/content/interaction.js:418:10
[00:09:18]                 │      webdriverClickElement@chrome://marionette/content/interaction.js:179:31
[00:09:18]                 │
[00:09:19]                 │ info Taking screenshot "/dev/shm/workspace/parallel/1/kibana/test/functional/screenshots/failure/discover app discover tab with new fields API field data the search term should be highlighted in the field data.png"
[00:09:19]                 │ info Current URL is: http://localhost:6111/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(extension),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:php),sort:!(!(%27@timestamp%27,desc)))
[00:09:19]                 │ info Saving page source to: /dev/shm/workspace/parallel/1/kibana/test/functional/failure_debug/html/discover app discover tab with new fields API field data the search term should be highlighted in the field data.html
[00:09:20]                 └- ✖ fail: discover app discover tab with new fields API field data the search term should be highlighted in the field data
[00:09:20]                 │      StaleElementReferenceError: The element reference of <mark> is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
[00:09:20]                 │       at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
[00:09:20]                 │       at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:565:13)
[00:09:20]                 │       at Executor.execute (node_modules/selenium-webdriver/lib/http.js:491:26)
[00:09:20]                 │       at runMicrotasks (<anonymous>)
[00:09:20]                 │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:09:20]                 │       at Task.exec (test/functional/services/remote/prevent_parallel_calls.ts:28:20)
[00:09:20]                 │ 
[00:09:20]                 │

Stack Trace

StaleElementReferenceError: The element reference of <mark> is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed
    at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:565:13)
    at Executor.execute (node_modules/selenium-webdriver/lib/http.js:491:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Task.exec (test/functional/services/remote/prevent_parallel_calls.ts:28:20) {
  remoteStacktrace: 'WebDriverError@chrome://marionette/content/error.js:181:5\n' +
    'StaleElementReferenceError@chrome://marionette/content/error.js:442:5\n' +
    'get@chrome://marionette/content/element.js:239:13\n' +
    'evaluate.fromJSON@chrome://marionette/content/evaluate.js:242:26\n' +
    'dispatch/</req<@chrome://marionette/content/listener.js:101:29\n' +
    'dispatch/<@chrome://marionette/content/listener.js:100:15\n'
}

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	3183	3184	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.6MB	1.6MB	+113.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	840.4KB	840.6KB	+197.0B

Unknown metric groups

API count

id	before	after	diff
`data`	3737	3739	+2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

[FieldFormats] fix register on start contract (elastic#106828)

215df6e

kibanamachine assigned Dosant Jul 28, 2021

kibanamachine added the backport This PR is a backport of another PR label Jul 28, 2021

kibanamachine enabled auto-merge (squash) July 28, 2021 12:08

kibanamachine mentioned this pull request Jul 28, 2021

[FieldFormats] fix register on start contract #106828

Merged

kibanamachine merged commit 4434e96 into elastic:7.x Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] [FieldFormats] fix `register` on start contract (#106828)#106994

[7.x] [FieldFormats] fix `register` on start contract (#106828)#106994
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-106828

kibanamachine commented Jul 28, 2021

Uh oh!

kibanamachine commented Jul 28, 2021

Standard Out

Stack Trace

API count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kibanamachine commented Jul 28, 2021

Uh oh!

kibanamachine commented Jul 28, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants