Skip to content

[7.x] [Lens] Move Lens functions to common (#105455)#106719

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-105455
Jul 26, 2021
Merged

[7.x] [Lens] Move Lens functions to common (#105455)#106719
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-105455

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* 🚚 First move batch to common

* 🚚 Second batch of move

* 🏷️ Import types only

* 🚚 Third batch

* 🚚 Fourth batch move

* 🚚 Another module moved

* 🚚 More function moved

* 🚚 Last bit of move

* ⚡ Reduce page load bundle size

* 🐛 Fix import issue

* 🐛 More import fix

* ✨ Registered functions on the server

* 🐛 Expose datatable_column as well

* ✅ Add server side expression test

* 🚚 Moved back render functions to public

* ✨ Add a timezone arg to time_scale

* 🔥 Remove timezone arg

* 🔥 Remove server side code for now

* 👌 Integrated feedback

* 🚚 Move back datatable render function

* 🏷️ Fix imports

* 🏷️ Fix missing export

* 🚚 Move render functions back!

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 26, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) July 26, 2021 13:29
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 705 731 +26

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 169 190 +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +23.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 14 22 +8
Unknown metric groups

API count

id before after diff
lens 185 206 +21

References to deprecated APIs

id before after diff
lens 168 160 -8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dej611

@kibanamachine kibanamachine merged commit 1b92b79 into elastic:7.x Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants