Skip to content

[7.x] [APM] Typed client-side routing (#104274)#105745

Merged
dgieselaar merged 1 commit intoelastic:7.xfrom
dgieselaar:backport/7.x/pr-104274
Jul 15, 2021
Merged

[7.x] [APM] Typed client-side routing (#104274)#105745
dgieselaar merged 1 commit intoelastic:7.xfrom
dgieselaar:backport/7.x/pr-104274

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* [APM] @kbn/typed-router-config

* [APM] typed route config

* Breadcrumbs, wildcards

* Migrate settings, home

* Migrate part of service detail page

* Migrate remaining routes, tests

* Set maxWorkers for precommit script to 4

* Add jest types to tsconfigs

* Make sure transaction distribution data is fetched

* Fix typescript errors

* Remove usage of react-router's useParams

* Add route() utility function

* Don't use ApmServiceContext for alert flyouts

* Don't add onClick handler for breadcrumb

* Clarify ts-ignore

* Remove unused things

* Update documentation

* Use useServiceName() in ServiceMap component
@dgieselaar dgieselaar added the backport This PR is a backport of another PR label Jul 15, 2021
@dgieselaar dgieselaar enabled auto-merge (squash) July 15, 2021 12:02
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1570 1538 -32

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.2MB -115.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 40.2KB 40.3KB +71.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit b54873d into elastic:7.x Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants