Skip to content

[7.x] Enable CSS-in-JS styling with emotion (#98157)#105223

Merged
thompsongl merged 1 commit intoelastic:7.xfrom
thompsongl:backport/7.x/pr-98157
Jul 12, 2021
Merged

[7.x] Enable CSS-in-JS styling with emotion (#98157)#105223
thompsongl merged 1 commit intoelastic:7.xfrom
thompsongl:backport/7.x/pr-98157

Conversation

@thompsongl
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* emotion deps

* kbn-babel

* kbn-test

* examples

* babel-plugin-styled-components config

* css prop type fixes

* type context

* declaration location

* some emotion types resolved

* clean up

* emotion v10 accomodations

* types

* kbn-crypto

* kbn-telemetry-tools

* bazel

* eslint rule; shared file regex array

* update paths

* Update packages/kbn-eslint-plugin-eslint/rules/module_migration.js

Co-authored-by: Spencer <email@spalger.com>

* remove placeholder styles

* doc api changes

* snapshot updates

* storybook comments

* use constant

* bump new deps

* condense versions

Co-authored-by: Spencer <email@spalger.com>
@thompsongl thompsongl added the backport This PR is a backport of another PR label Jul 12, 2021
@thompsongl thompsongl enabled auto-merge (squash) July 12, 2021 14:11
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 912.9KB 912.5KB -380.0B
apm 4.3MB 4.3MB -8.7KB
canvas 1.2MB 1.2MB -4.8KB
cases 528.5KB 527.3KB -1.1KB
console 904.1KB 903.3KB -859.0B
core 229.8KB 229.8KB +3.0B
crossClusterReplication 290.3KB 287.5KB -2.8KB
dashboard 221.7KB 221.3KB -436.0B
data 165.4KB 164.4KB -963.0B
dataEnhanced 79.9KB 79.4KB -499.0B
dataVisualizer 1.1MB 1.1MB -3.6KB
devTools 4.6KB 4.6KB -69.0B
discover 422.3KB 420.3KB -2.0KB
enterpriseSearch 2.1MB 2.1MB -13.5KB
expressionRevealImage 11.6KB 11.5KB -37.0B
fileUpload 787.6KB 787.4KB -185.0B
fleet 740.0KB 732.7KB -7.3KB
graph 1.1MB 1.1MB -858.0B
grokdebugger 532.0KB 531.9KB -150.0B
home 164.1KB 163.1KB -1.0KB
indexLifecycleManagement 248.7KB 246.4KB -2.3KB
indexManagement 1.3MB 1.3MB -7.9KB
indexPatternFieldEditor 22.2KB 22.0KB -186.0B
indexPatternManagement 553.2KB 549.0KB -4.2KB
infra 1.7MB 1.7MB -10.5KB
ingestPipelines 691.2KB 687.9KB -3.3KB
inputControlVis 83.3KB 83.0KB -291.0B
inspector 18.1KB 17.9KB -211.0B
kibanaOverview 21.9KB 21.5KB -387.0B
kibanaReact 312.1KB 312.1KB -20.0B
kibanaUtils 105.8KB 105.8KB +2.0B
lens 1.5MB 1.5MB -4.2KB
licenseManagement 126.7KB 126.0KB -726.0B
lists 272.6KB 272.4KB -255.0B
logstash 46.8KB 46.3KB -463.0B
management 17.1KB 17.1KB -50.0B
maps 3.1MB 3.1MB -5.8KB
mapsLegacy 278.0KB 278.0KB +1.0B
ml 5.9MB 5.9MB -20.0KB
monitoring 733.6KB 725.9KB -7.7KB
observability 483.8KB 481.7KB -2.2KB
osquery 905.4KB 904.1KB -1.3KB
painlessLab 28.4KB 28.0KB -392.0B
presentationUtil 59.9KB 59.4KB -470.0B
regionMap 273.9KB 273.8KB -43.0B
remoteClusters 162.9KB 161.4KB -1.5KB
reporting 70.4KB 69.9KB -543.0B
rollup 229.9KB 227.8KB -2.1KB
savedObjectsManagement 141.9KB 140.7KB -1.2KB
savedObjectsTagging 76.6KB 76.0KB -623.0B
searchprofiler 653.0KB 652.4KB -571.0B
security 781.5KB 774.8KB -6.7KB
securitySolution 6.3MB 6.3MB -14.0KB
snapshotRestore 461.6KB 453.7KB -7.9KB
spaces 279.1KB 276.8KB -2.4KB
stackAlerts 663.1KB 662.3KB -763.0B
telemetryManagementSection 2.5KB 2.5KB +41.0B
tileMap 277.9KB 277.9KB -10.0B
timelines 266.0KB 265.3KB -701.0B
timelion 197.4KB 197.4KB -7.0B
transform 927.3KB 924.5KB -2.8KB
triggersActionsUi 1.6MB 1.6MB -4.6KB
uiActionsEnhanced 11.3KB 11.3KB -24.0B
upgradeAssistant 161.7KB 159.9KB -1.9KB
uptime 955.3KB 949.2KB -6.0KB
visDefaultEditor 225.7KB 224.5KB -1.2KB
visTypeMarkdown 10.9KB 10.8KB -115.0B
visTypeMetric 17.1KB 17.0KB -49.0B
visTypePie 75.0KB 74.9KB -99.0B
visTypeTable 102.4KB 102.2KB -133.0B
visTypeTagcloud 17.8KB 17.7KB -99.0B
visTypeTimelion 69.2KB 69.1KB -117.0B
visTypeTimeseries 1007.7KB 1001.6KB -6.1KB
visTypeVega 2.4MB 2.4MB -269.0B
visTypeVislib 564.7KB 564.4KB -323.0B
visTypeXy 113.5KB 113.0KB -582.0B
visualizations 101.2KB 101.1KB -164.0B
visualize 91.9KB 91.7KB -169.0B
watcher 841.7KB 839.6KB -2.1KB
total -187.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 8.9KB 9.0KB +120.0B
apm 40.1KB 40.2KB +113.0B
banners 11.7KB 11.7KB -1.0B
canvas 409.8KB 409.1KB -750.0B
cases 130.0KB 130.0KB +31.0B
charts 88.5KB 88.5KB +33.0B
console 22.3KB 22.4KB +72.0B
core 421.6KB 420.6KB -1.0KB
crossClusterReplication 25.1KB 25.2KB +72.0B
dashboard 329.3KB 329.2KB -119.0B
dashboardEnhanced 24.7KB 24.7KB +77.0B
data 842.5KB 842.4KB -150.0B
dataEnhanced 18.0KB 18.1KB +105.0B
dataVisualizer 15.8KB 15.9KB +121.0B
devTools 16.4KB 16.5KB +72.0B
discover 93.0KB 92.8KB -241.0B
embeddable 158.9KB 158.8KB -42.0B
enterpriseSearch 14.7KB 14.8KB +72.0B
esUiShared 192.6KB 192.1KB -436.0B
expressionRevealImage 9.0KB 9.0KB +39.0B
expressions 213.0KB 213.1KB +32.0B
fileUpload 23.2KB 23.4KB +148.0B
fleet 448.2KB 448.3KB +90.0B
globalSearchBar 34.6KB 34.5KB -92.0B
graph 11.1KB 11.2KB +72.0B
grokdebugger 7.4KB 7.5KB +72.0B
home 16.1KB 16.2KB +72.0B
indexLifecycleManagement 50.1KB 49.9KB -175.0B
indexManagement 36.8KB 36.9KB +72.0B
indexPatternFieldEditor 83.1KB 82.6KB -543.0B
indexPatternManagement 19.1KB 19.1KB -4.0B
infra 142.3KB 142.5KB +167.0B
ingestPipelines 22.4KB 22.5KB +72.0B
inputControlVis 9.7KB 9.8KB +34.0B
inspector 40.2KB 40.2KB -28.0B
kbnUiSharedDeps-elastic 2.6MB 2.6MB +2.0B
kbnUiSharedDeps-js 6.4MB 6.4MB +16.0KB
kibanaOverview 30.7KB 30.8KB +72.0B
kibanaReact 146.8KB 146.6KB -182.0B
kibanaUtils 172.5KB 172.6KB +121.0B
lens 28.7KB 28.8KB +81.0B
licenseManagement 17.9KB 17.9KB +72.0B
licensing 13.7KB 13.7KB -11.0B
lists 6.6KB 6.6KB +30.0B
logstash 21.0KB 21.0KB +72.0B
management 16.2KB 16.3KB +72.0B
maps 65.0KB 65.0KB -37.0B
mapsLegacy 62.9KB 62.8KB -147.0B
ml 64.5KB 64.6KB +72.0B
monitoring 45.5KB 45.5KB -23.0B
navigation 18.0KB 18.0KB +73.0B
newsfeed 18.4KB 18.4KB -15.0B
observability 54.9KB 55.0KB +167.0B
osquery 14.0KB 14.1KB +38.0B
painlessLab 19.8KB 19.8KB +7.0B
presentationUtil 74.6KB 74.7KB +118.0B
regionMap 18.2KB 18.2KB +27.0B
remoteClusters 14.2KB 14.3KB +72.0B
reporting 56.6KB 56.5KB -91.0B
rollup 33.8KB 33.9KB +72.0B
runtimeFields 20.7KB 20.7KB -69.0B
savedObjects 52.3KB 52.1KB -147.0B
savedObjectsManagement 34.2KB 34.3KB +72.0B
savedObjectsTagging 33.4KB 33.4KB -54.0B
searchprofiler 40.4KB 40.4KB +72.0B
security 85.4KB 84.8KB -689.0B
securityOss 10.0KB 9.9KB -42.0B
securitySolution 202.2KB 202.3KB +72.0B
share 83.1KB 83.2KB +56.0B
snapshotRestore 41.2KB 41.3KB +72.0B
spaces 42.9KB 42.4KB -518.0B
stackAlerts 17.7KB 17.7KB +72.0B
telemetry 36.8KB 37.0KB +155.0B
telemetryManagementSection 23.0KB 23.3KB +254.0B
tileMap 16.5KB 16.5KB +27.0B
timelines 210.2KB 210.2KB +9.0B
timelion 9.5KB 9.6KB +72.0B
transform 19.0KB 19.0KB +72.0B
triggersActionsUi 89.4KB 89.3KB -92.0B
uiActions 38.3KB 38.4KB +35.0B
uiActionsEnhanced 231.7KB 231.5KB -248.0B
upgradeAssistant 29.3KB 29.3KB +72.0B
uptime 22.6KB 22.7KB +117.0B
urlDrilldown 21.0KB 21.2KB +129.0B
usageCollection 8.3KB 8.3KB +34.0B
visDefaultEditor 33.9KB 33.9KB -48.0B
visTypeMarkdown 12.3KB 12.3KB -33.0B
visTypeMetric 21.5KB 21.6KB +25.0B
visTypePie 20.2KB 20.2KB +27.0B
visTypeTable 8.2KB 8.2KB +72.0B
visTypeTagcloud 14.4KB 14.5KB +27.0B
visTypeTimelion 24.3KB 24.4KB +27.0B
visTypeTimeseries 24.5KB 24.5KB +11.0B
visTypeVega 54.6KB 54.6KB +3.0B
visTypeVislib 32.5KB 32.5KB +27.0B
visTypeXy 63.5KB 63.4KB -97.0B
visualizations 55.5KB 55.4KB -33.0B
visualize 27.5KB 27.6KB +72.0B
watcher 22.7KB 22.7KB +72.0B
total +14.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit b13e90e into elastic:7.x Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants