Skip to content

[7.x] [canvas] Reduce bundle size by combining SCSS imports (#102822)#103805

Merged
clintandrewhall merged 2 commits intoelastic:7.xfrom
clintandrewhall:backport/7.x/pr-102822
Jun 30, 2021
Merged

[7.x] [canvas] Reduce bundle size by combining SCSS imports (#102822)#103805
clintandrewhall merged 2 commits intoelastic:7.xfrom
clintandrewhall:backport/7.x/pr-102822

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/canvas/public/components/var_config/var_config.tsx
@clintandrewhall clintandrewhall added the backport This PR is a backport of another PR label Jun 30, 2021
@clintandrewhall clintandrewhall enabled auto-merge (squash) June 30, 2021 00:31
@clintandrewhall clintandrewhall disabled auto-merge June 30, 2021 03:01
@clintandrewhall clintandrewhall enabled auto-merge (squash) June 30, 2021 04:33
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1106 1043 -63

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -21.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 461.7KB 461.7KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit d7d3aa2 into elastic:7.x Jun 30, 2021
@clintandrewhall clintandrewhall deleted the backport/7.x/pr-102822 branch July 9, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants