[7.x] [Enterprise Search] Test coverage pass (#103406)#103433
Merged
cee-chen merged 1 commit intoelastic:7.xfrom Jun 28, 2021
Merged
[7.x] [Enterprise Search] Test coverage pass (#103406)#103433cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen merged 1 commit intoelastic:7.xfrom
Conversation
* Do not collect code coverage on test_helpers
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
* Fix uncovered type line
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
* Fix branch coverage on index.tsx
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
* Crawler DomainsTable test coverage/improvements
- Fix test failing locally due to timezones by increasing the timezone offset
- Cover missing branch line by adding a domain with no `lastCrawl`
- Remove unnecessary extra beforeEach with dupe re-shallow/mounts
- move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: