Skip to content

[7.x] Dashboard locator (#102854)#103388

Merged
streamich merged 1 commit intoelastic:7.xfrom
streamich:backport/7.x/pr-102854
Jun 25, 2021
Merged

[7.x] Dashboard locator (#102854)#103388
streamich merged 1 commit intoelastic:7.xfrom
streamich:backport/7.x/pr-102854

Conversation

@streamich
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Add dashboard locator

* feat: 🎸 expose dashboard locator from dashboard plugin

* Use dashboard locator in dashboard drilldown

* Add tests for dashboard locator

* Fix dashboard drilldown tests after refactor

* Deprecate dashboard URL generator

* Fix TypeScript errors in exmaple plugin

* Use correct type for dashboard locator

* refactor: 💡 change "route" attribute to "path"

* chore: 🤖 remove unused bundle

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@streamich streamich added the backport This PR is a backport of another PR label Jun 25, 2021
@streamich streamich enabled auto-merge (squash) June 25, 2021 05:58
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 265 266 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 133 137 +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 325.4KB 328.0KB +2.6KB
dashboardEnhanced 24.9KB 24.7KB -195.0B
total +2.4KB
Unknown metric groups

API count

id before after diff
dashboard 145 160 +15

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit bfb66d0 into elastic:7.x Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants