Skip to content

[7.x] [Enterprise Search] Set up initial KibanaPageTemplate (#102170)#102431

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102170
Jun 17, 2021
Merged

[7.x] [Enterprise Search] Set up initial KibanaPageTemplate (#102170)#102431
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102170

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Set up shared EnterpriseSearchPageTemplate component

* Set up product-specific page templates + setPageChrome

+ misc tech debt - create AS components/layout/index.ts for imports

* Set up navigation helpers for EuiSideNav usage

- Update react_router_helpers to pass back props as a plain JS obj instead of only working with React components (+ update react components to use new simpler helper)

- Convert SideNavLink active logic to a plain JS helper

* Set up top-level product navigations

NYI: sub navigations (future separate PRs)

* Set up test_helpers for inspecting pageHeaders

- primarily useful for rightSideItems, which often contain conditional logic

* Initial example: Convert RoleMappings views to new page template

Minor refactors:
+ remove unnecessary type union
+ fix un-i18n'ed product names
+ add full stop to documentation sentence
+ add semantic HTML tags around various page landmarks (header, section)

* EUI feedback: add empty root parent section

* Revert Role Mappings union type removal

- but shenanigans it a bit to take our i18n'd shared product names (requires as const assertion)

- done to reduce merge conflicts for Scotty / make his life (hopefully) a bit easier between ent-search and Kibana

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 16, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) June 16, 2021 22:26
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1433 1449 +16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 14.3KB 14.5KB +238.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit b3c9c18 into elastic:7.x Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants